From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5+VdEVsJ7GLLvyAAWB0awg (envelope-from ) for ; Thu, 04 Aug 2022 14:00:59 -0400 Received: by simark.ca (Postfix, from userid 112) id 353FF1EA05; Thu, 4 Aug 2022 14:00:59 -0400 (EDT) Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=SC1EhRAy; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 82F9D1E9EB for ; Thu, 4 Aug 2022 14:00:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D39F6385AC1C for ; Thu, 4 Aug 2022 18:00:57 +0000 (GMT) Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 1894A3857379 for ; Thu, 4 Aug 2022 17:59:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1894A3857379 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 2AEA4100480EF for ; Thu, 4 Aug 2022 17:59:27 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Jf82otQ9eWBOVJf82oVJ7E; Thu, 04 Aug 2022 17:59:27 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=cpReL30i c=1 sm=1 tr=0 ts=62ec08ff a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=biHskzXt2R4A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=LWJfBM5zbrbmOy9hDI4A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fs+Jcgp0wg6zGE+g+HaJw4juELunccfKb2JJ5cxsEjo=; b=SC1EhRAyH8SHwNFMSXSJdkE2a3 lNs5ui2C+KNsh/QgAVJ4TZrDfr9jEdVpDpcjsNtQ+YTi+ltJV/TAQJofHKHAysi7e9IAVUFbil9er qGLz41/tdXl/xnW72scMCCiK1; Received: from 71-211-185-228.hlrn.qwest.net ([71.211.185.228]:56268 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oJf82-001YTx-9f; Thu, 04 Aug 2022 11:59:26 -0600 From: Tom Tromey To: Alan Modra via Gdb-patches Subject: Re: Don't use BFD_VMA_FMT in gdb and sim References: X-Attribution: Tom Date: Thu, 04 Aug 2022 11:59:25 -0600 In-Reply-To: (Alan Modra via Gdb-patches's message of "Thu, 4 Aug 2022 15:02:17 +0930") Message-ID: <87zggjga9u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.228 X-Source-L: No X-Exim-ID: 1oJf82-001YTx-9f X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-228.hlrn.qwest.net (murgatroyd) [71.211.185.228]:56268 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alan Modra Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Alan" == Alan Modra via Gdb-patches writes: Alan> Like commit b82817674f, this replaces BFD_VMA_FMT "x" with PRIx64, Alan> and casts to promote bfd_vma to uint64_t. Alan> Tested with both 64-bit and 32-bit gdb builds, and 64-bit make check. Alan> OK to install? Alan> diff --git a/gdb/windows-tdep.c b/gdb/windows-tdep.c Alan> index 2516e4ed058..c2823191b42 100644 Alan> --- a/gdb/windows-tdep.c Alan> +++ b/gdb/windows-tdep.c Alan> @@ -1011,10 +1011,10 @@ is_linked_with_cygwin_dll (bfd *abfd) Alan> || import_table_va >= idata_section_end_va) Alan> { Alan> warning (_("\ Alan> -%s: import table's virtual address (0x%" BFD_VMA_FMT "x) is outside .idata \ Alan> -section's range [0x%" BFD_VMA_FMT "x, 0x%" BFD_VMA_FMT "x[."), Alan> - bfd_get_filename (abfd), import_table_va, idata_section_va, Alan> - idata_section_end_va); Alan> +%s: import table's virtual address (0x%" PRIx64 ") is outside .idata \ Alan> +section's range [0x%" PRIx64 ", 0x%" PRIx64 "[."), Alan> + bfd_get_filename (abfd), (uint64_t) import_table_va, Alan> + (uint64_t) idata_section_va, (uint64_t) idata_section_end_va); For gdb, it's more normal to use %s and 'hex_string (value)'. hex_string will add the 0x as well. It's fine to call it multiple times in a single printf. thanks, Tom