From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EAaXB/knBWOnLSwAWB0awg (envelope-from ) for ; Tue, 23 Aug 2022 15:18:17 -0400 Received: by simark.ca (Postfix, from userid 112) id 1BD331E4A7; Tue, 23 Aug 2022 15:18:17 -0400 (EDT) Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pFIoED94; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BB70B1E222 for ; Tue, 23 Aug 2022 15:18:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6D9383857C61 for ; Tue, 23 Aug 2022 19:18:12 +0000 (GMT) Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 382393858D1E for ; Tue, 23 Aug 2022 19:17:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 382393858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 90C65100423EE for ; Tue, 23 Aug 2022 19:17:43 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id QZPDoNVvfCokGQZPDoNcNA; Tue, 23 Aug 2022 19:17:43 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=c8Nu/Txl c=1 sm=1 tr=0 ts=630527d7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=biHskzXt2R4A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=7d_E57ReAAAA:8 a=QCMyyC-ROsaT73ruXXYA:9 a=vLSSZjyX2LUA:10:uccc_2email_address a=ul9cdbp4aOFLsgKbc677:22 a=jhqOcbufqs7Y1TYCrUUU:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=URPG4uCT5DLwLAOcJt6AXbK/+qEQRh1hTVnBqrjsNpQ=; b=pFIoED94lVPiWNHA3YKYIi5FSS djUiQ/YIdM1ja7ypCrRWpGPYJtT53IMr4EBdndUp4A0Mh7xYYqOJvwGZy/Iou+uoxcz7esA9WdFLW 7EUZU+J4xUX/K0PoqejNXsGTf; Received: from 71-211-185-105.hlrn.qwest.net ([71.211.185.105]:56348 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oQZPC-003zaC-LF; Tue, 23 Aug 2022 13:17:42 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH] gdb, gdbsupport: configure: factor out yes/no/auto value checking References: <20220817175341.1594352-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Tue, 23 Aug 2022 13:17:41 -0600 In-Reply-To: <20220817175341.1594352-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Wed, 17 Aug 2022 13:53:41 -0400") Message-ID: <87zgfubwh6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.105 X-Source-L: No X-Exim-ID: 1oQZPC-003zaC-LF X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-105.hlrn.qwest.net (murgatroyd) [71.211.185.105]:56348 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> From: Simon Marchi Simon> Factor out the code that checks that a value is yes/no or yes/no/auto. Simon> Add two macros to gdbsupport/common.m4 and use them in gdb/configure.ac Simon> I inspected the changes to configure. Other than whitespace changes, we Simon> have some benign changes to the error messages (one of them had an error Simon> actually). There are changes to the --enable-source-highlight and Simon> --enable-libbacktrace handling, but setting enable_source_highlight / Simon> enable_libbacktrace was not really useful anyway, they already had the Simon> right value. This looks reasonable to me. Simon> +AC_ARG_ENABLE([gdbmi], I was very surprised to learn today that this really can be disabled. Simon> -AC_ARG_ENABLE(source-highlight, Simon> - AS_HELP_STRING([--enable-source-highlight], Simon> - [enable source-highlight for source listings]), Simon> - [case "${enableval}" in Simon> - yes) enable_source_highlight=yes ;; Simon> - no) enable_source_highlight=no ;; Simon> - *) AC_MSG_ERROR(bad value ${enableval} for source-highlight option) ;; Simon> -esac], Simon> -[enable_source_highlight=auto]) Simon> +AC_ARG_ENABLE([source-highlight], Simon> + [AS_HELP_STRING([--enable-source-highlight], Simon> + [enable source-highlight for source listings])], Simon> + [GDB_CHECK_YES_NO_VAL([$enableval], [--enable-source-highlight])], Simon> + [enable_source_highlight=auto]) This defaults to 'auto' but, weirdly, doesn't let one explicitly specify 'auto'. I wonder if switching it to GDB_CHECK_YES_NO_AUTO_VAL would be an improvement. Tom