From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 51keMJJXxWN8JhgAWB0awg (envelope-from ) for ; Mon, 16 Jan 2023 08:56:34 -0500 Received: by simark.ca (Postfix, from userid 112) id B40501E128; Mon, 16 Jan 2023 08:56:34 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=n51+YaFs; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AFA081E110 for ; Mon, 16 Jan 2023 08:56:33 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DD44C385842C for ; Mon, 16 Jan 2023 13:56:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DD44C385842C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673877392; bh=0kGaPeiTwiB8+FCmJ25N/e+to0FX2+Vn747CFjYJTRE=; h=To:Cc:Subject:References:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=n51+YaFsUJokIUlphSXqNk9Zk4rFac59hzeVUMTmqD+aI2U7kYi8G4+HtaE5Cu4/M p/7rJ46bhb/wjEkTWGvPARUI1rV1jnxVAuYA56ol7vis/vZdpFJiIDWOaU3ekkcF6h EQhQGB6bgqcxNt7U9PeM3L6HUtbiSCxoTwPphTRI= Received: from mail.esperi.org.uk (icebox.esperi.org.uk [81.187.191.129]) by sourceware.org (Postfix) with ESMTPS id 46F093858D33 for ; Mon, 16 Jan 2023 13:51:12 +0000 (GMT) Received: from loom (nix@sidle.srvr.nix [192.168.14.8]) by mail.esperi.org.uk (8.16.1/8.16.1) with ESMTPS id 30GDp7bH018461 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 16 Jan 2023 13:51:08 GMT To: Enze Li via Binutils Cc: Enze Li , gdb-patches@sourceware.org, enze.li@gmx.com, eliz@gnu.org, schwab@linux-m68k.org Subject: Re: [PATCH v2] libctf: update regexp to allow makeinfo to build document References: Emacs: because editing your files should be a traumatic experience. Date: Mon, 16 Jan 2023 13:51:07 +0000 In-Reply-To: (Enze Li via Binutils's message of "Sat, 14 Jan 2023 12:23:26 +0800") Message-ID: <87zgaioaes.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DCC--Metrics: loom 1480; Body=6 Fuz1=6 Fuz2=6 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Nick Alcock via Gdb-patches Reply-To: Nick Alcock Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 14 Jan 2023, Enze Li via Binutils verbalised: > While trying to build gdb on latest openSUSE Tumbleweed, I noticed the > following warning, > > checking for makeinfo... makeinfo --split-size=5000000 > configure: WARNING: > *** Makeinfo is too old. Info documentation will not be built. > > then I checked the version of makeinfo, it said, > ====== > $ makeinfo --version > texi2any (GNU texinfo) 7.0.1 > > Copyright (C) 2022 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > ====== > > After digging a little bit, it became quite obvious that a dot is > missing in regexp that makes it impossible to match versions higher than > 7.0, and here's the solution: > > - | egrep 'texinfo[^0-9]*(6\.[3-9]|[7-9][0-9])' >/dev/null 2>&1; then > + | egrep 'texinfo[^0-9]*(6\.[3-9]|[7-9]\.[0-9])' >/dev/null 2>&1; then > > However, Eli pointed out that the solution above has another problem: it > will stop working when Texinfo 10.1 will be released. Meanwhile, he > suggested to solve this problem permanently. That is, we don't care > about the minor version for Texinfo > 6.9, we only care about the major > version. > > In this way, problem solved permanently, thanks to Eli. Looks good to me: approved. (I can commit it if you like.) This should probably also be backported to the 2.40 branch to keep the latest released GNU tools building with the latest released GNU tools.