From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0BpRLaaQB2RiqwcAWB0awg (envelope-from ) for ; Tue, 07 Mar 2023 14:29:42 -0500 Received: by simark.ca (Postfix, from userid 112) id B62001E223; Tue, 7 Mar 2023 14:29:42 -0500 (EST) Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Spe+Pdpv; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 662C91E128 for ; Tue, 7 Mar 2023 14:29:42 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8F18E3851C20 for ; Tue, 7 Mar 2023 19:29:40 +0000 (GMT) Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id E0D703858C2C for ; Tue, 7 Mar 2023 19:29:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E0D703858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id F35681003FAE1 for ; Tue, 7 Mar 2023 19:29:27 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Zd03p9Cfx9Qs9Zd03pkiyF; Tue, 07 Mar 2023 19:29:27 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=PJbKRdmC c=1 sm=1 tr=0 ts=64079097 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=uj_nBiDE0tHucYd30c8A:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UXC0froqme9AYVnfULbPku5MjAx6536UiWcQVhVoz9M=; b=Spe+PdpvLf78oMvrDhRCSCgAdy FVdyF+9iju5r5Wuh7sYevSYyyOLeSjIAZcwj3ZlQi9sPtNZGEEdOv3G5g9bTuGFUFR8vsIgpBu2xc HKU32mbT+U5miruvqLzzsdQpa; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:45454 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pZd03-000qHm-9o; Tue, 07 Mar 2023 12:29:27 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi , Simon Marchi Subject: Re: [PATCH 2/3] gdb: make interp::m_name an `const char *` References: <20230302203224.118345-1-simon.marchi@efficios.com> <20230302203224.118345-3-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 07 Mar 2023 12:29:24 -0700 In-Reply-To: <20230302203224.118345-3-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 2 Mar 2023 15:32:23 -0500") Message-ID: <87zg8oqs17.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pZd03-000qHm-9o X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:45454 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> I realized that the memory for interp names does not need to be Simon> allocated. The name used to register interp factory functions is always Simon> a literal string, so has static storage duration. If we change Simon> interp_lookup to pass that name instead of the string that it receives Simon> as a parameter (which does not always have static storage duration), Simon> then interps can simply store pointers to the name. I wish we had a way to detect/enforce this. That way lies rust I suppose. Simon> So, change interp_lookup to pass `factory.name` rather than `name`. Simon> Change interp::m_name to be a `const char *` rather than an std::string. Reviewed-By: Tom Tromey Tom