From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hS1YIJaQLWXtmi8AWB0awg (envelope-from ) for ; Mon, 16 Oct 2023 15:35:50 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=MT5kZPVt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 79B201E0C1; Mon, 16 Oct 2023 15:35:50 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5A64D1E091 for ; Mon, 16 Oct 2023 15:35:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A6FA13857BA4 for ; Mon, 16 Oct 2023 19:35:47 +0000 (GMT) Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 874B43858C66 for ; Mon, 16 Oct 2023 19:35:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 874B43858C66 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 874B43858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697484936; cv=none; b=xt/emMWw8q+K8a/WjZmxXJlXa6Iw+biQMOhtfzh4yAxMq9cDwskMq3HuQ19kbPgRetytwp8kKqn1OMKlgZZTKOjaWG0K2stnU6ulvdOwY2oGrJ4PgAUKs43tOu2ggXnIUjCNdZs4Wel2Cx6DwgrcV59ZP0pFsxDFzvyWVRUcLwY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697484936; c=relaxed/simple; bh=efMEmdl6LZuz7qxE/feT8ARJMu6Z0t0pdzr8Tctb3Sk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IT8SMKs8vWus6SazvEXP0y5+rmq5o7g+VyDw7z3IuD4+DwKceaLtzRgWNDXIXqZc5CjjZ4AN2ehD+lutFKfNLdTcyscKrhD+hl0Mpl8y+KaJJWFltWrEOkVn6F1t1hJ7+aOmS2f2cabpkMW/nA8iLrT98mVnRj/GncYUAwf1ZLE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTP id sSNfqF4NXnGhUsTNEqdVIa; Mon, 16 Oct 2023 19:35:32 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id sTNDqShCwXLJvsTNDq9Udo; Mon, 16 Oct 2023 19:35:31 +0000 X-Authority-Analysis: v=2.4 cv=H87IfsUi c=1 sm=1 tr=0 ts=652d9083 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=zd2uoN0lAAAA:8 a=WZ0gUgH_mLJe_WgZE9wA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qjeomG9+RA/BV4K7hTav3Wz2KfrDGpmCiMb+JyO3oig=; b=MT5kZPVtkHMdRaog/8X/lekdm3 tDj/BfS+ZxMG9uKxBS/hrpeVOr+FioIl+YXFWqtSw9xHpWwcKSaRhLRyo6ihfbKqAmerALh0LHsJp QVVcnOorfcaXXvOBdiZpOddCE; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:33208 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1qsTNC-001FuJ-2v; Mon, 16 Oct 2023 13:35:30 -0600 From: Tom Tromey To: Lancelot SIX Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 06/11] gdb: Use std::string_view instead of gdb::string_view References: <20231013144418.3180617-1-lancelot.six@amd.com> <20231013144418.3180617-7-lancelot.six@amd.com> <87il78x49e.fsf@tromey.com> X-Attribution: Tom Date: Mon, 16 Oct 2023 13:35:30 -0600 In-Reply-To: (Lancelot SIX's message of "Mon, 16 Oct 2023 16:06:04 +0100") Message-ID: <87zg0iqs1p.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qsTNC-001FuJ-2v X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (murgatroyd) [71.211.130.31]:33208 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPFi2KBJynVROBP1VWQVkP7nC2/N5m7WJOTwxl2gyy7ey2Vp5JWFqN0XQ18JGjkr2fdMpq9Y1oItKr4Du5M90ki3zsZVREWC5CLLRAuXjzYenghWO+3i UzPJFVLtWQK++jLNpJtjQ5rpH/OAkXtPoMImRVTLREDc1aR2L4RUQU5rYxTZNHC8OH/knaEj0vjCnV0MDPyjJ7gtnVoLcZTueNg= X-Spam-Status: No, score=-3018.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Lancelot" == Lancelot SIX writes: Lancelot> + std::string_view name; Lancelot> + if (const char *name_str = keyname (ch); Lancelot> + name_str != nullptr) We should probably discuss whether to allow this construct before letting it in. Personally I'm ok with it. Tom