From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /K9iC+Dc7mUcSQIAWB0awg (envelope-from ) for ; Mon, 11 Mar 2024 06:28:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZuuPSlK0; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1A79B1E0D2; Mon, 11 Mar 2024 06:28:48 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 03E821E0AC for ; Mon, 11 Mar 2024 06:28:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 845E53858C32 for ; Mon, 11 Mar 2024 10:28:45 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8BFD33858CD1 for ; Mon, 11 Mar 2024 10:27:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8BFD33858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8BFD33858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710152844; cv=none; b=W7yNTwxgGxrGrqbQlucHwor5TvbSwCvsUqTLmP1XqdJdqvHpOH7A8hLV58VEWYyk6wjG9YGVIUmTsr/BFTrJh4fCbcAOEN1eIawEaNdpU37UT//jaxM4RBr4vveG+h3SUbzQnR+uSNdYAAA1Y0+r0U5yRwNKbc+Jp4xmZJJ2Ryw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710152844; c=relaxed/simple; bh=GJqCr3cat3aR6cBQUpQg9hisSPMbdD85sDszZ7Z5d3Y=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bcLqqjTjtv65/7hIlO5IlUXvnJ/rC9LMcY7+xO3cv6vwYKJ6ppdIHSHE7s2KSix44XB01k2IIQQoX1DLaQs4u9W6jhujf5RF60+WIu06KKfSGG+nhaT2DumY9opEb/8DfJSCyMXlw2FZgWm28pNrzx2Ok1cCh8kXoBnwU4fciY0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710152843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KQ0CpLnMwEwUbOBSdVO3GtnqMALfh9T3sDocHY8okZY=; b=ZuuPSlK0NP5I5wUpfVAu0LVqmWizk47b6r5T2aFEQvGoAAlP6zOzd7V0vrr3Duf7qg+gXv RTIpVyOcRDB737clta2ObvpYfM3/Bd+YwoGAgRGUnRjk5rjOhNgJ7fk1w0J/wMvTIuroth 5BRrp49RBH+YcK/qvhWGAAUDF98fM7Y= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-hG1WvI1_MMKGs7nY1S3ZsQ-1; Mon, 11 Mar 2024 06:27:22 -0400 X-MC-Unique: hG1WvI1_MMKGs7nY1S3ZsQ-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a448cfe2266so340680566b.2 for ; Mon, 11 Mar 2024 03:27:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710152839; x=1710757639; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KQ0CpLnMwEwUbOBSdVO3GtnqMALfh9T3sDocHY8okZY=; b=mTwjCEc84RBi2/ZWMfRbzLgYLxi2PvYNWng71qJCoJN8EpNMkPYKIV1gTDd40ZgUZm 9RAr+ywYezJp4N61uR1zlB09HEvXeowRQQXXrpLGmv1f4h8qSvMSOiTj38uV5xxc0Fm8 zhfAjfEjcRZz5yxQBTIPdeT0/KG7uMnKJGEFP6qIE/dA8nxQTntXYxlB/uqQ4UKd7vpT JueCy5vLjZHjYV2bheC7nG5na8X7owNtslIh+gga+htcsZmk0OU58iu8UB5b9NwOQp4U 1ciUqyWHLC8HJb2Foq3rctFQiPuXU1pwz2qe2g+6wGAw6zc6k3CRYDx4ycZYSmbrxPwC hbjw== X-Forwarded-Encrypted: i=1; AJvYcCWbEmPoT8MixAh6vyrg6oNj/nruXSG4ji/nG509n8hqbAMdENoEYq2VoDj5CBCyDkUTVpmj0lzahUex2FVNADG3/3tQCt49+MBgHw== X-Gm-Message-State: AOJu0YwbNUwPDSfa9CZ+XJDcngDNj/RiWvJB86GLfn1Pwz9xaZvCZDGg 6jMG0b4yvY1QREblrfJrGmGRoO/xTjy9yOTpVBO2apdR0EH0yvOhwu+lRok5Y1pE1tHm2Pu6tsQ Ld2BcvtvOayKBGSj+8Kanlh/WCUH8Lie9/9ttxnZwKE4u9KxTH9OOOPLKS5L4F0FoQgY= X-Received: by 2002:a17:906:2849:b0:a40:18ad:3fcc with SMTP id s9-20020a170906284900b00a4018ad3fccmr3607838ejc.36.1710152839118; Mon, 11 Mar 2024 03:27:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHH6jd/YQV5VVWz+nvTDaHWjlL93Prddr0r7MmsDGXTZKrGCDmoDrHJbtl/xhRX9IMfPVdWzQ== X-Received: by 2002:a17:906:2849:b0:a40:18ad:3fcc with SMTP id s9-20020a170906284900b00a4018ad3fccmr3607818ejc.36.1710152838583; Mon, 11 Mar 2024 03:27:18 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id k20-20020a17090627d400b00a453b2261b4sm2716529ejc.184.2024.03.11.03.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 03:27:18 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: Tom Tromey , gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Revert "Pass GUILE down to subdirectories" In-Reply-To: <8734u0m1d1.fsf@tromey.com> References: <20240123001928.787780-1-tom@tromey.com> <87bk8s8der.fsf@redhat.com> <8734u0m1d1.fsf@tromey.com> Date: Mon, 11 Mar 2024 10:27:17 +0000 Message-ID: <87zfv5oygq.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Tom Tromey writes: >>> This reverts commit b7e5a29602143b53267efcd9c8d5ecc78cd5a62f. >>> >>> This patch caused problems for some users when building gdb, because >>> it would cause 'guild' to be invoked with the wrong versin of guile. >>> On the whole it seems simpler to just back this out. >>> >>> * Makefile.in: Rebuild. >>> * Makefile.tpl (BASE_EXPORTS): Remove GUILE. >>> (GUILE): Remove. >>> * Makefile.def (flags_to_pass): Remove GUILE. > > Andrew> Is it going to be possible to merge this with GCC in stage 4? Would be > Andrew> super useful if we could as this is still causing problems. > > We can always check it in to gdb now and then to gcc at some later date. > If that sounds ok to you, I'll go ahead & do it. Thanks, that would be great, and would certainly fix the build problems I see. Sorry for the late reply. Thanks, Andrew