From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QCjzNZzuAmZO+RYAWB0awg (envelope-from ) for ; Tue, 26 Mar 2024 11:49:48 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=JzrQj0AE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D68331E0C1; Tue, 26 Mar 2024 11:49:48 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B32251E08C for ; Tue, 26 Mar 2024 11:49:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 55E363858417 for ; Tue, 26 Mar 2024 15:49:46 +0000 (GMT) Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 92807385843B for ; Tue, 26 Mar 2024 15:49:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 92807385843B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 92807385843B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::134 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711468165; cv=none; b=fJ6WjIRqkKYtxfI4R73mtftG2KWi9VznwsSPAkpkJqGhvJLGK5CQcUNatBXESydH+NydGgOo9q8IN1cYeG5GPMoDWmiAouGmhHS/pkFWMKuji1Zj43iqncJ3/5VYmnQfRNf6/+ghIfCFRN7uV+Mh4cKj8o43q3CdVSgI9eCgyzI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711468165; c=relaxed/simple; bh=xIBjCb8rDOhexq8QxaV8+GburXn6kyO0dBnrhID61KM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=URmOhVAMX6UteTyvlQQSL1+im2HxzUKbwidRCHhFDHi9ZQHNy7U8niXyaWtk2ppIRk3D8NFjuwkgrd9F1ZBORdEJQ7dz39utVtX57+LOTHk42V3NqqOhsb0GY9TfOb+Xp0rKcrKFmseJIuhSHATVAkyaACLupfx66lQpXyUc9Vc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x134.google.com with SMTP id e9e14a558f8ab-366b3b6d527so19867245ab.0 for ; Tue, 26 Mar 2024 08:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1711468161; x=1712072961; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=baC+spXzTsWQUtATNZzv95X3BxBDIicFr3DbeLnQGYU=; b=JzrQj0AENXQEg7+hwdNBEXKVu1i2u5PItIkJOred0yBFvh+9UiZHFhbw3YcEwI2Vq7 7Rm8nS+gCz3kn/5PUUKnKmTMWmsWblUMKZTp+QFh/XkCm8e9UxmRZwY5ZgdLc5z5Txdq um5QCJ9XBf6wZR9adBVo8KIrCYuRjuq1M2eN0XQh8Gr6BoORAQJpNT790Mv6rj7WNlmx cN6Rm+xxsb2L2DBcheoyq2TqyzaFisp7Y8RPpP1mOyi/z7VPUkpEjpcMCLrbkqrUuY7s ER2l1u2GsU9nX/amxA4JySY473tjKshv54sc2yUe1Fhw5mR1n1A9mzp0xD0RvQbTdkvb jjOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711468161; x=1712072961; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=baC+spXzTsWQUtATNZzv95X3BxBDIicFr3DbeLnQGYU=; b=iIpws6nqWLxLbBiNvNLH3fSmgYlbPq67ER2DygYY0WUHXq4KybGUQ4vMs+l13S9UWA QNy0on8gt/qKs8CZ4P+QSnyNocph4lqf33O7QjwNvySxZOxBNQ0G3tc3/6OdDmfrRVBD z4eHbSB0cQ3JweKnwviE+797yaeAepFOtSicGSdNR2K6lklHdgDuD3akWYkGHzR5xJNg UGmEEV9cXiP38UJ0ULiXgoarqCAO3l9skyYv/46DryZFWpFvo48+BDXgp0A2MIDrXZoO zFgEkyc66eMZRrZ662cLMBnhDRtaNM0DVPWLUIi2Cs3Bq/2uN6oVQAzTmyvAQq8kM/Sh HLVQ== X-Gm-Message-State: AOJu0YyzHtWNFaUuUxG6NHjRLzWEB+1jMqMJcuyFInzX+tevL51uIemO z3dNhJ014BsH6I2Ydmvb96XUFg8DIr+pED0KTB2fWWj0vtVSJ/MZNIBRmNGZ1A== X-Google-Smtp-Source: AGHT+IEdP7HnRkwHzQgPYJ9xy3l2sIcqBxjg2I7A9ontgaJSGAaxC374lG52VpY9cDELVjQKsp+iyA== X-Received: by 2002:a92:cbca:0:b0:366:80a1:5f78 with SMTP id s10-20020a92cbca000000b0036680a15f78mr1203070ilq.2.1711468160749; Tue, 26 Mar 2024 08:49:20 -0700 (PDT) Received: from murgatroyd (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id q6-20020a92c006000000b0036897e06ea6sm873936ild.77.2024.03.26.08.49.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 08:49:20 -0700 (PDT) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Capture warnings when writing to the index cache References: <20240312144033.77496-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 26 Mar 2024 09:49:19 -0600 In-Reply-To: <20240312144033.77496-1-tromey@adacore.com> (Tom Tromey's message of "Tue, 12 Mar 2024 08:40:33 -0600") Message-ID: <87zfulat8g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom Tromey writes: Tom> PR symtab/30837 points out a race that can occur when writing to the Tom> index cache: a call to ada_encode can cause a warning, which is Tom> forbidden on a worker thread. Tom> This patch fixes the problem by arranging to capture any such Tom> warnings. Tom> This is v2 of the patch. It is rebased on top of some other changes Tom> in the same area. v1 was here: Tom> https://sourceware.org/pipermail/gdb-patches/2024-February/206595.html Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30837 I'm checking this in now. Tom