From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id osJmEKeVEWddahEAWB0awg (envelope-from ) for ; Thu, 17 Oct 2024 18:54:31 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dZdYog8a; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2634F1E35F; Thu, 17 Oct 2024 18:54:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 324D81E05C for ; Thu, 17 Oct 2024 18:54:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 78CFC3858C53 for ; Thu, 17 Oct 2024 22:54:29 +0000 (GMT) Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 0FDBD3858D20 for ; Thu, 17 Oct 2024 22:53:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FDBD3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0FDBD3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729205647; cv=none; b=XRB2iTL0f+ZmEhEY3O0xotpOWAq38u0xkIkljUWLMOuOUR2ldytMAfm5tNQBqk1ZwEDx398j0f8lWU5MoGlw87pHN1CJIXrc2KMDcON0X9qtVbYGCDsh7DSPlnBzpfLsUMyJ/1x6aSFa0vfl7XyK6C7wljuadnhE5j2zpL2HD3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729205647; c=relaxed/simple; bh=BWyGOw2kEMaEDefyyW+vhWCfyL1ZfYL0+bLWavdVlH4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YkraKNJjsC+ZCSb/kgJDwKnr/AaRo2P+CueaYdLDOeA74atS3/9gR/XF8uGdu3EuI5A58wDzb8Kb7ACE1UPVZfrM4tgFJ4WWfHUbck5VpvbGlx+tF3A3BSGawAvZum+mt1VagKPVPJdZR/7EW1L+xVR8WQSLkpwOLY43rO5gCQc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTPS id 1TIVtkykGumtX1ZNUtpLUi; Thu, 17 Oct 2024 22:53:56 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 1ZNTtUPys65gF1ZNTt9qzs; Thu, 17 Oct 2024 22:53:55 +0000 X-Authority-Analysis: v=2.4 cv=Z58nH2RA c=1 sm=1 tr=0 ts=67119583 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=DAUX931o1VcA:10 a=ItBw4LHWJt0A:10 a=qCsYKog63kosVXntK5sA:9 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=e1dS8SALRSsoMpEUIJU3mMxoWWpunOWuX1tXqBJkw/o=; b=dZdYog8aLCAba4FTugRHvqWj4m 05ZBK0LNrOYf+lqt0iKqcI5YMbBOkTPvBS6E9Ai8Gyi+3FnWpefi7J6JQy9Cu0ou0vM7APei01I4K 9Mzdr9uBaILH817Vwgayxie4L; Received: from c-67-190-86-1.hsd1.co.comcast.net ([67.190.86.1]:53132 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1t1ZNS-001ABl-1u; Thu, 17 Oct 2024 16:53:54 -0600 From: Tom Tromey To: Guinevere Larsen Cc: Thiago Jung Bauermann , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v5 1/5] gdb: make gdbarch store a vector of frame unwinders In-Reply-To: (Guinevere Larsen's message of "Mon, 14 Oct 2024 15:18:08 -0300") References: <20241001184235.3710608-1-guinevere@redhat.com> <20241001184235.3710608-2-guinevere@redhat.com> <87iku7hfz5.fsf@tromey.com> <87v7xydrz5.fsf@linaro.org> X-Attribution: Tom Date: Thu, 17 Oct 2024 16:53:53 -0600 Message-ID: <87zfn21gu6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 67.190.86.1 X-Source-L: No X-Exim-ID: 1t1ZNS-001ABl-1u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: c-67-190-86-1.hsd1.co.comcast.net (prentzel) [67.190.86.1]:53132 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfA0LYsQ8OK/Dle4PKrxHSlm+mla75ZJDiEX6m2rgl5XCUpbf3CxYMpS/SNXkqcPPfbJgIg6kOkc6uLeHznV8nADv1z932bGV0wknpFSsoP5K72Vdz2ny AKdnLMlqqOeX7NAm7vztqBuFusNgkcm2sPPjXbSMsIJXrm3YN6O2/UoKTwly2i2aXyqLRiI/KzwaS32dQzWNQoyFHJk/ffsKiw8= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Guinevere> I am not a big fan of the registry subsystem, so I would prefer to Guinevere> keep it as a simple vector. However, if you are concerned about the Guinevere> opaqueness change, Tromey, I can try to make it more opaque. I just Guinevere> personally find that registry tends to make the code too opaque for Guinevere> programmers as well as the program itself :-) I think gdbarch is exposed to a lot of tdep code, and this code in particular to do questionable things. So, preserving some opacity makes sense to me. Guinevere> So if you want more separation, I would personally prefer to look into Guinevere> only receiving a copy of the unwinder list, and gdbarch is responsible Guinevere> for adding and removing things. Just let me know and I can give it a Guinevere> shot I think it would be more worthwhile to understand your objections to the registry. It seems to me that switching back to using it is just a couple of lines of code, so it makes me think there must be some pretty strong reason. Tom