From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mMz3NP3mYmdXtCAAWB0awg (envelope-from ) for ; Wed, 18 Dec 2024 10:15:09 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=INEmpxNT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D600D1E097; Wed, 18 Dec 2024 10:15:09 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 624401E091 for ; Wed, 18 Dec 2024 10:15:09 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 108623858C53 for ; Wed, 18 Dec 2024 15:15:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 108623858C53 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=INEmpxNT Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 077C33858D20 for ; Wed, 18 Dec 2024 15:14:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 077C33858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 077C33858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734534876; cv=none; b=nitagIRTdSUdYtDVLb2V7bmYYOGzXGpjD5ZmUEQrMGsoQsIPfEhTtXeBzrWfZg0+w7kiX9fbcQzlwvsjPKi6KZ07kXoKQOSiHLtjLi02UuF6EX0FLWmEDB8mfqoO5KnQvDix20la3tvXcTWSJfH09nmq/AI0zDWlvA6o4vvwaYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734534876; c=relaxed/simple; bh=5n9DcsPiy/Yp5OYv1M34gVcNaXxugpXlemvyL4rBm+o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=v8zg0CqvBwYMJKTDag2j8CbD62OC7MIHi+ADzDOgPtBVbBF9GP/owLXmMVaQ2AEyONXSyicjCzkoAlgTrDHxIAp9xLMX69/MDARACxor+63rq5jTXWrxzEqm56PsvIG9VpsYcdRAJjaEfwfNZCKBS/6upCDxW4ndbfWsevocWaY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 077C33858D20 Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id NuB5toFXIumtXNvkxt94ph; Wed, 18 Dec 2024 15:14:35 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id NvkwtSHoXCgT6Nvkwtz2OC; Wed, 18 Dec 2024 15:14:34 +0000 X-Authority-Analysis: v=2.4 cv=XvwxOkF9 c=1 sm=1 tr=0 ts=6762e6da a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=RZcAm9yDv7YA:10 a=ItBw4LHWJt0A:10 a=pGLkceISAAAA:8 a=fBi2dOGJhUlYgr8-IL4A:9 a=zZCYzV9kfG8A:10 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DtRihQ7TTFPKgUjPNdKgc+flbS8XMTUz/j0uZR2y86s=; b=INEmpxNTIP0mmzx4O1NeHqYqrL Lu1mzxorydTWkNzUIZyY254dlV+7+xAQzXAeeNevM7XKW+uAVYyqnawnANRBaGnDDvuYM6UCqGPpv H2tAs74cHDa6ymlcaszDMnsSR; Received: from 97-122-113-155.hlrn.qwest.net ([97.122.113.155]:37274 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tNvkv-0015Ac-2J; Wed, 18 Dec 2024 08:14:33 -0700 From: Tom Tromey To: Flavio Cruz Cc: gdb-patches , Tom Tromey Subject: Re: [PATCH] Hurd: remove VLA usage. In-Reply-To: (Flavio Cruz's message of "Wed, 18 Dec 2024 01:27:19 -0500") References: X-Attribution: Tom Date: Wed, 18 Dec 2024 08:14:32 -0700 Message-ID: <87zfktauqv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.113.155 X-Source-L: No X-Exim-ID: 1tNvkv-0015Ac-2J X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-113-155.hlrn.qwest.net (murgatroyd) [97.122.113.155]:37274 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfBnk7JDzYvIIPktjNqpcPWVRzGh4pU5JXEMXBbnkON+1fvjKz4YqfiZsKjONxRl9cuk2jaESKRpLgV7bAkZdFDafpKw4Z60R9ieazhMvHQTd3aj6EZ2R gvKU+MtfHYQPUwfBaKvM9Yu/6JAqKbSSEYfLLHSCihmUXzYDRq5Mfw4YL75ADW1sXV0rClHyUiUllA5oUiP+ZyudUGM87gaZ88U= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Flavio" == Flavio Cruz writes: Flavio> Compilation will fail with -Werror=vla, which seems to be the default. Flavio> Note that we can allocate just an array of num_threads pointers, Flavio> hence the change. Flavio> - /* Which thread in PROCS corresponds to each task thread, & the task. */ Flavio> - struct proc *matched[num_threads + 1]; Flavio> + /* Which thread in PROCS corresponds to each task thread. */ Flavio> + struct proc **matched = XNEWVEC (struct proc *, num_threads); Since this is in C++ code I think you could use std::vector matched (num_threads + 1, nullptr); Flavio> + xfree (matched); ... that would avoid the explicit free. Tom