From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BPCoNqEUy2isUQgAWB0awg (envelope-from ) for ; Wed, 17 Sep 2025 16:05:53 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=f4e4BHIk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C92231E0BA; Wed, 17 Sep 2025 16:05:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CC5031E04C for ; Wed, 17 Sep 2025 16:05:52 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5D7563858C41 for ; Wed, 17 Sep 2025 20:05:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D7563858C41 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=f4e4BHIk Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 10C853858D29 for ; Wed, 17 Sep 2025 19:58:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 10C853858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 10C853858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::630 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758139087; cv=none; b=e+aCUtsiNlAtHkxP4AtMA49NVYNIxCiybAwiiiK+kpyF44n0JQ5mNqhvWpDTO3ESklQRGtfZ1Car++bNZiQJ4sB+bgTssAKf4VHVbDxdl028Bl1VDNj9YURVn+JQobQ8aSoRzEpxXyxDlqzH1zzxoCzsTUTWf4yB2kzqNIEMtaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758139087; c=relaxed/simple; bh=P5saqpimiSQujhtAWsCr0mX+ZzYWvzYoeYQj4+V4q6U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TYultf8UsOKsJDvIiNV6HGZLtMnSnBSVVKRN8mx+JdHyyijhPNDw92+Jy/ST0rkcsunKk5DRd9XCyxUfGt8fZLU6t7EwbS/pEKCqpIiZA6AZC5uX5QD7j/kyclIIZsogMQOOXR1bgXz2rN3KQNlkKG0A9o271xQ3ggmhODgfB7I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10C853858D29 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-2697899a202so3167725ad.0 for ; Wed, 17 Sep 2025 12:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758139086; x=1758743886; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=M6YYZEy+VHudQNIumSRrmzaZl+rbAb4LY2rGzzliKSo=; b=f4e4BHIkLAboa0XvNQPCv0YQlt6DaCU8Md3XHrr4mp4RrlqbmU4HsIizDWyHudyQb3 QMOvHegyeSJw7/PFi3X5liYzDgv9ueORUkL8k5eso557P9ZFR/K8FI+VH1YdL7IKxHa7 o5mZujbHpxTYzhdybQ9cvMtpJyeVDEtv86PSWP4+d+NJnDqhy/B9AMAA4CcwgnnlZYmW 6/UbBBLIZXdXqJd3/VDeld+hBRR7CYnLejQx0kZiwCO9J1hjWblWLeCwAnY4XdPDYhra FRwlh71GtZveF8yY+5MMSxF0c+NKBQXBvg7zWS/8mjMsh8/F0OZkXDVPgl2geWAxLRG8 nSSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758139086; x=1758743886; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M6YYZEy+VHudQNIumSRrmzaZl+rbAb4LY2rGzzliKSo=; b=KKepYw5VZQaPGQXxNYA6MT8IMdJZ8Dpv15PjuW0DhxiBm772tnhQyvaiL1qg3QtYoJ 5DJFlKws0Z4JY7hd6G5yPiagNASTv9EZKA/zbVYxNOeSw0iRqhcdBZKbxyYauDCJGt89 pGw79venrb7yPPhe/UvkEXqZF3ufOzUq8Dvr3bbktsPrtsmn1ct4edE86Uwx2uh68PKF S0RXpJhXAvaELRCuYDGGkXvQAYoQtqYiFAr60MSvjk+BZkdPffCD2OL0a9mReGbA2hp5 qKnZgRkiKE0fxo3u+NfUCfwIFo1pnbia20ZghU314fre7wgeiEvsmsz9PoaXCJY3PpYy VTXw== X-Gm-Message-State: AOJu0YwhKhjk3BVIpk7m+9p8SQ0GYbSig7eqI7AjH+HSoZkfWY2TJyEW xfsJ1jUNrcJT7jQKuSA8k5VmiDP7ajEar45zoO9xkx19AB2R/GW2aGc491hQH/DgWgE= X-Gm-Gg: ASbGncsqvIpxbYoHotAyxwvIC47lpZUkjuDiytKyOMqBlP3bBeP6ttZ+7EtKlm7IBiX B8UIqZXifozq2hQhlgv2sGu5q85wr58xnHMiCWfMcPWFdhSydUFoLMHYgmIC8WaolcIjF0/c1K6 TbUATsd5kC4ST7Qq9xIaQ2rkDC/v5BU7YxvlxOAE1meIJZogIzwXZByqbZ7nEninevdAuiZyQXY yOPZneGVRqW3+Xn2wvbmuLy8EyS26nqpiwUswYFnX2N2MIZyP6d9AL+u8VTGxqRehrNDeXFP0VQ zuENLHAUfLbR/MnAAP3zGVZ1B9PyuIQH/yEU2uE742OY1FVNxUNAiH5d4VX/igdrwMj4X6lk86s Xm5t57YczpiRWkUTB6FQZNVGkYgA8pj4USFawUa6n3xZfs6Gp6A== X-Google-Smtp-Source: AGHT+IF5kwlkd7Zy0TEUv4V2CRooHoTFc9i/3Z6YPJrY/dwZh1X9Y8wLWQMKyvBtNHXwG167Nhlz7w== X-Received: by 2002:a17:902:e547:b0:251:a3b3:1572 with SMTP id d9443c01a7336-2697c815446mr8528195ad.9.1758139086109; Wed, 17 Sep 2025 12:58:06 -0700 (PDT) Received: from localhost ([2804:14d:7e39:88d6:f449:fc35:8c8e:e44]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32ea101ef2fsm2611915a91.5.2025.09.17.12.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 12:58:05 -0700 (PDT) From: Thiago Jung Bauermann To: Luis Cc: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [PATCH] GDB: aarch64: Use GCS features to calculate hash of struct aarch64_features In-Reply-To: <2e586040-adbc-4a66-96ef-8f6364af4abb@gmail.com> (Luis's message of "Wed, 17 Sep 2025 18:42:38 +0100") References: <20250917010349.263373-1-thiago.bauermann@linaro.org> <2e586040-adbc-4a66-96ef-8f6364af4abb@gmail.com> User-Agent: mu4e 1.12.11; emacs 30.2 Date: Wed, 17 Sep 2025 16:58:03 -0300 Message-ID: <87zfasetro.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Luis writes: > Hi! > > On 17/09/2025 02:03, Thiago Jung Bauermann wrote: >> Luis noticed that when adding the gcs and gcs_linux members to struct >> aarch64_features in my Guarded Control Stack patch series, I neglected to >> modify struct hash::operator() to take them into account >> when computing its hash. >> This can cause GDB to use the wrong aarch64_features object during a >> debugging session. >> Regression tested on aarch64-linux-gnu. >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33440 >> Suggested-by: Luis >> --- >> This should also be backported to the branch. Unfortunately I'm not able >> to set the target milestone in Bugzilla. >> gdb/arch/aarch64.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> diff --git a/gdb/arch/aarch64.h b/gdb/arch/aarch64.h >> index 679d845df74e..0fcdba7fb7d6 100644 >> --- a/gdb/arch/aarch64.h >> +++ b/gdb/arch/aarch64.h >> @@ -94,6 +94,10 @@ namespace std >> /* SME2 feature. */ >> h = h << 1 | features.sme2; >> + >> + h = h << 1 | features.gcs; >> + h = h << 1 | features.gcs_linux; >> + >> return h; >> } >> }; > > Thanks for the patch, this is OK for both master and the branch. > > Approved-By: Luis Machado Thanks! Pushed to the main branch as commit 86e6907244c8, and to gdb-17-branch as commit 4a21648ec38b. -- Thiago