Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] infcall: Add support for integer literals as reference function paramters
Date: Fri, 17 Oct 2025 08:49:52 -0600	[thread overview]
Message-ID: <87zf9ppoq7.fsf@tromey.com> (raw)
In-Reply-To: <92575c2eb6805095b41ebbe62ba99b81e4e5dd63.1760629738.git.keiths@redhat.com> (Keith Seitz's message of "Thu, 16 Oct 2025 08:48:58 -0700")

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> This patch attempts to mitigate the shortcomings of passing literals
Keith> to inferior function calls requiring references.  The specific use case here
Keith> is std::map's operator[]:

Keith> (gdb) print int_map[1]
Keith> Attempt to take address of value not located in memory.

I didn't see in the text or the patch what the method type really is.

Keith> +#include <map>
Keith> +#include <string>

It's better for tests not to use libstdc++ stuff if possible, and to
just write out a method with the problem signature in a locally-defined
type.

Keith> -if {[build_executable $testfile.exp $testfile $srcfile {debug c++}] == -1} {
Keith> +if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} {

This results in starting an extra gdb that is immediately exited.

Tom

  reply	other threads:[~2025-10-17 14:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16 15:48 Keith Seitz
2025-10-17 14:49 ` Tom Tromey [this message]
2025-10-20 19:00   ` Keith Seitz
2025-10-20 19:36 ` [PATCH v2] " Keith Seitz
2025-10-21 20:19   ` Tom Tromey
2025-10-22 12:05     ` Andrew Burgess
2025-10-22 13:21       ` Tom Tromey
2026-01-22 19:05       ` Keith Seitz
2026-01-23 14:07         ` Aktemur, Tankut Baris
2026-01-27 18:43           ` Keith Seitz
2026-01-27 19:01 ` [PATCH v4] " Keith Seitz
2026-01-28  8:24   ` Aktemur, Tankut Baris
2026-01-28 13:54   ` Andrew Burgess
2026-02-02 17:05     ` Aktemur, Tankut Baris
2026-02-02 17:21     ` Keith Seitz
2026-01-30 20:59   ` Tom Tromey
2026-02-02 16:58     ` Keith Seitz
2026-02-02 17:22       ` Aktemur, Tankut Baris
2026-02-12 16:31       ` Tom Tromey
2026-03-12 14:14 ` [PATCH v5] infcall: Add support for integer literals as reference function parameters Keith Seitz
2026-03-12 16:23   ` Tom de Vries
2026-03-12 16:45     ` Keith Seitz
2026-03-12 17:12 ` [PATCH v6] " Keith Seitz
2026-03-17 14:10   ` Andrew Burgess
2026-03-17 18:11     ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zf9ppoq7.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox