From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TJJQB2MqQGmlBQIAWB0awg (envelope-from ) for ; Mon, 15 Dec 2025 10:33:55 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IoC0FiZy; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0C87D1E0B6; Mon, 15 Dec 2025 10:33:55 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2B1421E048 for ; Mon, 15 Dec 2025 10:33:54 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A3F734BA2E04 for ; Mon, 15 Dec 2025 15:33:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A3F734BA2E04 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IoC0FiZy Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1714A4BA2E05 for ; Mon, 15 Dec 2025 15:33:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1714A4BA2E05 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1714A4BA2E05 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765812808; cv=none; b=HA//iLCq/yQWv1wIpPRxTMwF9Ke4i2KlE2xf2j9Sf0mMcwxGgPQQc6JkaGxk/B8KksHbZFNrjwSX3iKcNjUMHbhDY30P8v2g0qByvx+e/H0BMVI1Cdvq7Oc5cvqM1xUULCqMvj+BVMBQcKwVjteXmdeUlnk8OaA/br4q8Nptdgk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765812808; c=relaxed/simple; bh=Mjp36rQHUPu9HIeMTkaybxjqfyYaDw0WBjMndIRoRE8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sUn5vPee+fTWBOa6tzFJv7uSjfvpLnZmHvURTtHTaF7zjBDvNJ4B2vZ89v2dVWd3lkxV+t6uMjmt1wlPtQ5L0n12AETOinun3xM4XlRULJsUJcKNViBffooQ3dZbNt90wxiXpTFdiNMgT+fCEmI1g9mo8JA1HPfWRtZ6quGcHss= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1714A4BA2E05 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765812807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mp3o/gCIe9M/nFlc1teFkTm8kgbQBqOfxdbmhQIVXvw=; b=IoC0FiZygPlfUDluWkihG8WNqENzTd5eeoIqGF9awSqY1JNvqHiNDZb8x1NKH3wVxmbcV5 IA9rp43hTxO5uga/RN5Dau6DUYvifsxUzmekAnj1LUWmw+4kcDDad7P9ZpUT+I43W7D3+i vfyV/qswuCQxkr8HDoGWWy3O9FpbF/Q= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-542-ubT1XoxwPZSkL4lzVmQISg-1; Mon, 15 Dec 2025 10:33:26 -0500 X-MC-Unique: ubT1XoxwPZSkL4lzVmQISg-1 X-Mimecast-MFC-AGG-ID: ubT1XoxwPZSkL4lzVmQISg_1765812805 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4779edba8f3so25240185e9.3 for ; Mon, 15 Dec 2025 07:33:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765812805; x=1766417605; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mp3o/gCIe9M/nFlc1teFkTm8kgbQBqOfxdbmhQIVXvw=; b=mI2ORx1FnwX8sDR9HA1eTe9fzHOisM0YDo5ewYuedhS3AXu6PU7sFFHWCERLiskbDu yaFagCQuphms3kJtVpI0wXv5P9fNumkYEf/qxhlOuaFacKHrElbBpqrGvWgsU3r35TRw /Z5LRyEhI/GeITVThRAR4MiD1An+44W1+2ZOjDOswiLMMNU4jF+8ptGpvlyxle5yKtFa lcUWL2/H0oLhg/fZREiBC6frf67MGkhyxaIuxTI+MTTJk8aeDnOTmg9sJ7/7Kf2Y7Kuh bEjqHG77ljmwnHkSJc910694WO1BxU4Q3+JUwhnevkKX6u/ApvIwsqJYgQ8xod0uF/+b iYsg== X-Gm-Message-State: AOJu0YwQRCYyAeG+yDcd3m/a1Qc6OyiEKUm0mtAajca4+FzWyjlB3mVD s0pk8n+tAeMQ2UQocV5YhhuEfN+G5lXfnvPPW20o0MiTs9Iyk48zvRL75UxaLz5aNK21MfJjBnr r/MmIdb+1/T1K+T7gyIxOR46fGi9y0PPNkFKaNych+8KRCaETmGRBNAeiD9nSCv1NnAzKMME= X-Gm-Gg: AY/fxX4K5wMkgV8ZIZoecRqI+c3Lmu+RNcwAPw0TClfdqB4puK24pxYCBT2D3Ouh1F/ k09dxmdE16tvTpX+3eS8Avam8Pmy8u0F1JojHLlqSw9MvjQU1CrPHl2wlAlCRAHcjKpLEWBUAV7 ZrEj9MvnjkUJYvG7Dcb1O9ft/dxzIUcwIPq2CeQXS4g8UQy5kNxgcKDVECuVvxYwPa9IVaa8AVp 84RLqSx1y99OtW51KY//C59kpHOCgb/UdW/AZQcaVMypQvxSPRuaiv8/h0S8NM6TBbG/24Pn539 fbVmQoAKXoPIYij5hSuTw1+HTBZbevLgntfks2nF+LG5o6MNTLPSyygariKAbDw6WoEkhWrhQgp cQdVt X-Received: by 2002:a05:600c:628d:b0:477:632c:5b91 with SMTP id 5b1f17b1804b1-47a8f8d21f7mr140271875e9.16.1765812804594; Mon, 15 Dec 2025 07:33:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IHMlakMdLv+e80ZOpO3eUEFKzdEgLkRRraPGlKDDniYOnWX1c431m68iDzp07wVN/iGoRK6vQ== X-Received: by 2002:a05:600c:628d:b0:477:632c:5b91 with SMTP id 5b1f17b1804b1-47a8f8d21f7mr140271595e9.16.1765812804210; Mon, 15 Dec 2025 07:33:24 -0800 (PST) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f4f424bsm194592735e9.10.2025.12.15.07.33.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 07:33:23 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv3 3/3] WIP: disable progress bars setting In-Reply-To: <875xae2s4t.fsf@tromey.com> References: <32f0ffdfd85e7a3d62a2dc3a7b06b01275412920.1764964133.git.aburgess@redhat.com> <87h5tz5zn8.fsf@redhat.com> <875xae2s4t.fsf@tromey.com> Date: Mon, 15 Dec 2025 15:33:21 +0000 Message-ID: <87zf7j4v5q.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: k3oKw4RD7Va0PGDbz3xy-cu7iljYn9WOy4bauLHymSo_1765812805 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Now, progress bars should display correctly on any width of output > Andrew> terminal over 50 characters, the minimum required. And the debuginfod > Andrew> tests should all pass as they turn off progress bars. > > Thanks. I have one nit but it's ok with this fixed. > > Andrew> diff --git a/gdb/cli-out.c b/gdb/cli-out.c > Andrew> index 5aa13a64271..ae60b65064b 100644 > Andrew> --- a/gdb/cli-out.c > Andrew> +++ b/gdb/cli-out.c > ...] > Andrew> +INIT_GDB_FILE (cli_out) > Andrew> +{ > ... > Andrew> + nullptr, > Andrew> + show_progress_bars_enabled, > Andrew> + &set_progress_bars_prefix_list, > Andrew> + &show_progress_bars_prefix_list); > Andrew> + > Andrew> + > Andrew> +} > > There's a couple extraneous empty lines here. > > Approved-By: Tom Tromey I cleaned up the empty lines, and pushed this series. Thanks, Andrew