From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GRtLBK8WYGlkNjMAWB0awg (envelope-from ) for ; Thu, 08 Jan 2026 15:42:23 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TJbIz2h1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0C1C51E0B6; Thu, 08 Jan 2026 15:42:23 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 962AC1E08D for ; Thu, 08 Jan 2026 15:42:22 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 290194BA2E04 for ; Thu, 8 Jan 2026 20:42:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 290194BA2E04 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TJbIz2h1 Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id D54794BA2E21 for ; Thu, 8 Jan 2026 20:41:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D54794BA2E21 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D54794BA2E21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767904872; cv=none; b=TiPzPoOKRC4cVSpdUn0wpiZyoWXyBeGdshN+lSyuBZigpNhG+y4oYMSgqoMN3mjMhpIfMfh0gSSL+NprciKTQrf2TcRQZFUV0V1UkuhGY9Pz8oxNyjo1vjSnLcIJerkR6lsbmEAyjnboHCwJY6HShKx/ngf2dMvczgv9i5/lP/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767904872; c=relaxed/simple; bh=3wzL1o0LijtdZ/LWt3rTh5uYc49zbbUTlDb9LTqrqiE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=CyVSSoHtexf5IfFRxv4EpqDvv2LQDRb6Py+4A/hBz4kG0cLToZUHOL48wGOKlO4p/9jepp+aacEU0h0KQxt0yrI+iDjuU6kDxwybpH+k4vCcVDgM5CIB6OucjBdn+Jqrzdy4dEyJk/sH/nRY6HEX7I17rFa32qw6Tb6Y4PThAuY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D54794BA2E21 Received: from eig-obgw-6003b.ext.cloudfilter.net ([10.0.30.175]) by cmsmtp with ESMTPS id dtvHvugvQipkCdwobvZJQM; Thu, 08 Jan 2026 20:41:05 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id dwoav9BbIhoT4dwoavq4M5; Thu, 08 Jan 2026 20:41:04 +0000 X-Authority-Analysis: v=2.4 cv=XZyJzJ55 c=1 sm=1 tr=0 ts=69601660 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=khrg-DhkuWUlFnVAuwUA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HPkx+RqV8uEMJH/fKzIE8ZbnnNoz8x/Cw4JaKoxERKA=; b=TJbIz2h1Q4lZObjamZ//rD7Wgu rUD5y7roqteggLtmS8PRI0fHWvfrl/w9S76zCJQ0yPWZ+iNMYvKV7OrxPkUvm25wrQ+5lmTInGs1B pOD80AGV+lscekKnRFg1hU5qd; Received: from 75-166-246-134.hlrn.qwest.net ([75.166.246.134]:43220 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vdwoa-000000048jy-1fos; Thu, 08 Jan 2026 13:41:04 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 8/8] gdb/xcoffread: stylistic cleanup In-Reply-To: <20260108193507.553779-9-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 8 Jan 2026 14:33:26 -0500") References: <20260108193507.553779-1-simon.marchi@efficios.com> <20260108193507.553779-9-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 08 Jan 2026 13:41:03 -0700 Message-ID: <87zf6nn8gw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.246.134 X-Source-L: No X-Exim-ID: 1vdwoa-000000048jy-1fos X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-246-134.hlrn.qwest.net (bapiya) [75.166.246.134]:43220 X-Source-Auth: tom+tromey.com X-Email-Count: 16 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCz3e7jZiO4XXIWKvsJcbiMu8Vvtq+kg3+J64774cKOkzGArXq82bbT/x65vqPTWidhRIMO5q3l2E8fQfTIZGjpdg2jiL4+hv0aP0KpJ7qffv0TXHoOl 7l82FOdbQFkJFyoWPxsrifDwICe9tCC9rlxYPYN1UjVy5Q852Bt82KsQ7uf7e6OFcngpLM03JpglljwtRTdZKGHd3fU5Fe/Cb3k= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> Do a few cleanups: Simon> - declaring variables where they are used Simon> - rename functions to be more precise Simon> - add explicit comparison against nullptr or 0 Simon> - remove struct/union keywords Simon> - remove or update outdated comments Looks good. Thanks for all the cleanups. Approved-By: Tom Tromey Tom