From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xR+rImo/4mlJ0B4AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 10:10:50 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NLVSNF3l; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 769921E0B1; Fri, 17 Apr 2026 10:10:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 91E501E0B1 for ; Fri, 17 Apr 2026 10:10:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 26B364CCCA0E for ; Fri, 17 Apr 2026 14:10:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26B364CCCA0E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NLVSNF3l Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 708894C900C5 for ; Fri, 17 Apr 2026 14:10:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 708894C900C5 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 708894C900C5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776435023; cv=none; b=rh74fATLna/Dd0Mx14y4tr4w1GbDMtD1u7fuOx7uq+XGCYVbc5s+v+i3cY8tvArx432HHzOwz3tMu+JXsVhTZufl8aOpc9sCUKgo4pq9b6sxyN3h0JU0OPCiBBgWjPwiph2PBONQSzI6jUTsbrstdW4s2MdApv67BxxMPjrOkew= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776435023; c=relaxed/simple; bh=X9y7kolDlBVG+Bry9UBrl/AjtUP8IjKyg8IGQLIjqoo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vozKsQ740YSfDAsscbKoiB6PPmbxfhd/K+9XRSpMlFdl1Mg3yS9I1vTnlaW5UuA2IIpBVaWiQ8h5ScC6YfPQqc/0d0tAj2fSXAcLB3VwT693WS1z6cXNeXdJvSU4KEQWBFCC5GDL0RSvPf1vQV3JSbYlQPLhc/8ISCCkrqq9K9E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 708894C900C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776435023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DnngJ/vfzYRcB5xvNsk6ZAOlvrc+e14BZEeC//YxTdM=; b=NLVSNF3lrRHge7SRxV6hBvrLPGLgNLgeGoZEKlndEcl9Guy8crBFU+osPQPC58vwTNSztx D2SjtCHPfFtYHuw9r13q1HTcSW64dVV5YNUPmj0NQOGB063jyFlwdmrrdgKk346ujvympM iBBjbGy1aTH3DwWOkfjn3h2lfrWq3O0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-195-NHokE9N_PBms4Ll_3VfQDA-1; Fri, 17 Apr 2026 10:10:11 -0400 X-MC-Unique: NHokE9N_PBms4Ll_3VfQDA-1 X-Mimecast-MFC-AGG-ID: NHokE9N_PBms4Ll_3VfQDA_1776435010 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43d1ceb2ddfso595405f8f.2 for ; Fri, 17 Apr 2026 07:10:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776435010; x=1777039810; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DnngJ/vfzYRcB5xvNsk6ZAOlvrc+e14BZEeC//YxTdM=; b=H2uO8gG3tF73RjL6qt7+IhJDeuqJRQVeK6LwOj69x5zmgiw2F95j3s0yKv4kpiPJJC ObCTVTsedzCytZ0CFta9mVYfgbtn4Vso2Ow13mVBNqtC3AnjdDM2O/6hrNONLpLvY5fs /PFGDzrk1pY2zzVjZrTp6CKdvv3ohGxGpeF7fEnqCbDxcihs5vO+Soo+WE4HXXyybaSz rBr4hPTf9oxvNvce5HtIifbyA8Wn3d7oX5CyEgYKu4jh5V5+m+s+tuI4eSVD9DdT016V 1YmUKUVBOG+Wkyc273d9fVbIBCkn7JlkDgWo2slO17JhD7gXrtgNOsj/gsH98dPR4NY/ vZ7A== X-Forwarded-Encrypted: i=1; AFNElJ/NXe4osNeUy8+GSbyioEFYC1YLLvlgc7rmoXfaJ4b1ZQ3zpTOnL+jHpgMHyEksH4xiD9IuzTMXegffaw==@sourceware.org X-Gm-Message-State: AOJu0YyMkcVSXICqocCFVqWhWZIpWVdZq5p86PKqSXF8QaRqceyGTYfj 1tO9Fsv7jFnvoxjOAYJ627hVQNUw7CPTiAnqsg9Ag1HnIeRdALb8YYFKdZQO4vN44y7ZZFx2sev CkRuhPc9n4uOBcZ++Q8YlBXUng6Mj5NzU/yG6BX9C22LjA22YDf7W14CmDdZutzDKH7gFIWk= X-Gm-Gg: AeBDieuMOHPX7MBGBrGmPu0nFpiVeVVt5bl3w3RrsvS1C5CeYTayRa4/qKN8ZZKrQyT efkf7xKXJbsQ8po8nZa2g0a6pfoteCJbDDdgMxfIdExxtyHL0GnvOCecPd6WLZNYVTz16wyvGAz x+WNtHnUPDWAqAvZ2G/Iz9RPGSGsRaD8WWk6tcVVPJawWtyyrWeBR9Mf99BJWX9HVeUijWnCtiL UCaIeftZ9wJqg8LcMK1Z8yk4emvFMPs5etpgYlp/LPd6lgcCnO6Tbl9OTn65kak5igaHkeUNPEq MZaGyf/tpcO32ZkeaQZb4GVZNZuhOgd1cjsIuYKUDy4pvnJyWEtRULSoEmaLqoDmhysjlkI52NV gmBCOEM1fJpwjQaaN9CCcNs1pzMvnMsKGjY2U6Q== X-Received: by 2002:a05:600c:8115:b0:488:904b:f31 with SMTP id 5b1f17b1804b1-488fb77e27cmr39298845e9.22.1776435009696; Fri, 17 Apr 2026 07:10:09 -0700 (PDT) X-Received: by 2002:a05:600c:8115:b0:488:904b:f31 with SMTP id 5b1f17b1804b1-488fb77e27cmr39298225e9.22.1776435009164; Fri, 17 Apr 2026 07:10:09 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc100162sm52840855e9.5.2026.04.17.07.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 07:10:08 -0700 (PDT) From: Andrew Burgess To: Tankut Baris Aktemur , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb, testsuite: fix regression in gdb.multi/multi-{exit, kill}.exp In-Reply-To: <20260417103502.2051279-1-tankut.baris.aktemur@intel.com> References: <20260417103502.2051279-1-tankut.baris.aktemur@intel.com> Date: Fri, 17 Apr 2026 15:10:07 +0100 Message-ID: <87zf31d6f4.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wmBjQ7sFeucF_k5eqUhi63--pJ7sQqu3BN5skho-mzY_1776435010 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tankut Baris Aktemur writes: > Commit d19862435df418a2ec78d078048f54d115c67a66 ("gdbserver: > require_running_or_break for the 'z' and 'vCont' packets") introduced > regressions in gdb.multi/multi-exit.exp and gdb.multi/multi-kill.exp. > > If the remote target has multiple inferiors and is resumed with > schedule-multi on, all processes may terminate, making the target have > no threads left. The target reports termination events to GDB. GDB > processes the first event and attempts to stop all processes. For > this, it sends 'vCont;t' packets to the target. But the patch mentioned > above required the target to be in a running state, which is not true > anymore. Therefore, target responds with an error. > > Fix the regression by reverting the 'require_running_or_return' > enforcement for vCont. Approved-By: Andrew Burgess thanks, Andrew > --- > gdb/testsuite/gdb.server/require-running.exp | 1 - > gdbserver/server.cc | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.server/require-running.exp b/gdb/testsuite/gdb.server/require-running.exp > index f06ece3496d..179c7ccc1ca 100644 > --- a/gdb/testsuite/gdb.server/require-running.exp > +++ b/gdb/testsuite/gdb.server/require-running.exp > @@ -49,7 +49,6 @@ set packets \ > "s" \ > "S00" \ > "T1" \ > - "vCont;c" \ > "x1234,1" \ > "X1234,1:00" \ > "z0,0x1234,0" \ > diff --git a/gdbserver/server.cc b/gdbserver/server.cc > index ebde831d603..37859f26b7e 100644 > --- a/gdbserver/server.cc > +++ b/gdbserver/server.cc > @@ -3575,7 +3575,6 @@ handle_v_requests (char *own_buf, int packet_len, int *new_packet_len) > > if (startswith (own_buf, "vCont;")) > { > - require_running_or_return (own_buf); > handle_v_cont (own_buf); > return; > } > -- > 2.34.1 > > Intel Deutschland GmbH > Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany > Tel: +49 89 991 430, www.intel.de > Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell > Chairperson of the Supervisory Board: Nicole Lau > Registered Seat: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928