From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yXFQJdvGfGpNFyEAWB0awg (envelope-from ) for ; Wed, 12 Aug 2026 15:17:47 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=LvADA6e1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 94F491E166; Wed, 12 Aug 2026 15:17:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 469991E09B for ; Wed, 12 Aug 2026 15:17:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E04244BB3B9E for ; Wed, 12 Aug 2026 19:17:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E04244BB3B9E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=LvADA6e1 Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by sourceware.org (Postfix) with ESMTPS id 07C684BAE7D9 for ; Wed, 12 Aug 2026 19:17:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07C684BAE7D9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 07C684BAE7D9 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786562242; cv=none; b=JSjsQ86UssJ2XbLoOwLkqmFpyFrIHPEO+LL/pGX99y/2y2K7ZcHPHi0yaHQDWjY8hYNiPPBXfYddQkheuES4M/vyKJShU3OgRU+1RI7kUKZn/e/TntFbTp+bt7MZUP5GYha4IZYyCjc788/ZCnofHPr+1ARJ86SBMV1MASDmyG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786562242; c=relaxed/simple; bh=WDODvIuLXEl8rAGn5ENfLo0S/zLgF2eCW2d/SoDmsuo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=MbPs1f83MCE1xCf3vWJB0OgIjrAfNtjZCxYqUvl4KlJ/aL0l2R1vormo+4kXEiK8uOJxsHjeJ8F3PQS7rDiQbM/UjMaFrWDrS50iOwaJKwYG1KxTQWCo6b4MTEn6HFgPzNd7suAz17RMkdJDkDZlOtUDlrIoD8Goj+qF3ITZ7Cw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=LvADA6e1 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 07C684BAE7D9 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-44aeefa1c00so214082fac.0 for ; Wed, 12 Aug 2026 12:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1786562241; x=1787167041; darn=sourceware.org; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=WDODvIuLXEl8rAGn5ENfLo0S/zLgF2eCW2d/SoDmsuo=; b=LvADA6e1+spxC4WkMuUBjyTL2LzAeZ28et5BvXzo3ie8hf0c5Tt8bGZjKQ1Idm2ot9 dDvb0FWAaQ4DIy9I4zzF2ywbg8Igk9cbFx+GZsKPF/GwKyne8vEw5TzY7bUuPzwMhD/r eakneocHhZfPmRrWjRJWRTSvepq/je/Swn+7qPNAUjzk8fYIZ5R5e1graxiQeRfYYKFE 2bVkQ8mBhBlSoumCsFUfzivda/eEy87r4+Kcf13Ehb9iw+w7Hphl8arZ6xnQ9FvzE3o/ pvzMFwFiPrqgKeWVINkGByprFGsTqUQWf52OZGgjkrgJhA/jElJ636QQ4yIy9e4+C89X 0OdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786562241; x=1787167041; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=WDODvIuLXEl8rAGn5ENfLo0S/zLgF2eCW2d/SoDmsuo=; b=TqkS2AgLllb46xmRs5b5fe8PtSnHhsfK3S4jNCFm5oC84VD9CzyVV6Q8AgOGKOldec ZTgeecczGxcn1wFsJVy16gQeBRkVJMrqO4j1zusltCqo0SllYw9p3R5BO5NsIPKIJxVg VCXDL1RFjcW1pVltBimRvk64XXKh9cwK055OxXQUdyABz0BQ6yzmy2q5+7ph0ozHdJ/+ ZjJqJzwc01LolbVrEW20iaO0qwHqfR6qTHw9lEiKySbErKNWZQ5MLKV3HuKIFna9HvCt /5axHCLUbQop10zKJuK/k4Hn/N3QOnUR1wkapYkj7OHvW9Llac5z66P4OQlFs7p6GnbU 8alg== X-Forwarded-Encrypted: i=1; AHgh+RqrpwyiSh66h5P/GpELPyHJP3e4CWVazaVn/h2BIJPMj7gm3xg6MEUzEdMTFiQFZI2Tp3lpxCfgJmqhEA==@sourceware.org X-Gm-Message-State: AOJu0YwfCirkBUk7rnBQKp1e24Cs0ESxOd2jAr+p2625RMLUB5AgJLfs Gh4BwnpYw5gvQaxQKj6JwPGY6MzHNln+HfyoKK8OWpNPv/0c4v5BNC8lKXJdRcK81S+ib0MfptQ AHxY= X-Gm-Gg: AR+sD10u6nevwRSEOBFlJ6bym6j2S8PehHgq7dH5jNmIXNUm0/QKdZJlRp7sY57+ogO LGtJR53zfWhosViiCUx3HvxfDTeQw2CaGZpREuaDaer4HIfxlTg83fxGzfWsdjkMnGGjoxGFyH7 tog3T/QMhvBCyaSUDQJ6r1Z7QCCDO+pBrWeA3OLHnT0CoFOL6i0QV0AHXqhpvSa2zf6qIPqiusT h6aQdZ82uw+zEGJ53GKjnv3zyoR9pJKNiWLF3rdePpF/4swO5ZD54d7v1wHf/oKjdGlQjmLHhHc 9pQfpHO8O9g+XdE+H3sUIeUzSmVcU14biXRuY0DoCd/p72fG+NKJwUI+ye4dxyYp8Em0RfyK4P+ mBzihNaVlWk5Rz2lIrjKe+dgLWcWrotqL+PMEtzPOwB/fPRiYYaz6M/QPKDbAKy4SA0XumTo8/9 gvzJFkW24zGt0rnv3mn9CZhJAkuh7VPkXHmwmak2GLhNhoFy/wBBpl0zxS4ZI+vag8+wTLedzfq Vr5fv3Z X-Received: by 2002:a05:6870:70a8:b0:456:e4ba:14c3 with SMTP id 586e51a60fabf-45e64a5da10mr15232fac.2.1786562241246; Wed, 12 Aug 2026 12:17:21 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-45e356c07fcsm2507253fac.18.2026.08.12.12.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 12:17:20 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Don't use F_SETFL in gdbreplay In-Reply-To: <25fcd57b-0459-4544-8725-8f7466ad9604@simark.ca> (Simon Marchi's message of "Wed, 12 Aug 2026 11:31:29 -0400") References: <20260717-f-setfl-v1-0-0d1eec47cf25@adacore.com> <20260717-f-setfl-v1-1-0d1eec47cf25@adacore.com> <25fcd57b-0459-4544-8725-8f7466ad9604@simark.ca> X-Attribution: Tom Date: Wed, 12 Aug 2026 13:17:16 -0600 Message-ID: <87zeyrw3lv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon> LGTM, but also it looks like you could drop: Simon> #if HAVE_FCNTL_H Simon> #include Simon> #endif I did this. Tom