From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 93MEFLdziGqYBTQAWB0awg (envelope-from ) for ; Fri, 21 Aug 2026 11:50:15 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=V5SCUTZa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 408FF1E033; Fri, 21 Aug 2026 11:50:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8F8D51E033 for ; Fri, 21 Aug 2026 11:50:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9EFCF4BB1C13 for ; Fri, 21 Aug 2026 15:50:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9EFCF4BB1C13 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=V5SCUTZa Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 955C24BAE7F3 for ; Fri, 21 Aug 2026 15:49:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 955C24BAE7F3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 955C24BAE7F3 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787327387; cv=none; b=TDJTfBPnh37jnYEhFeBkazFSr6Y/FQzpXII8/fduEpLXjq5cgueZ+VnBumif15BXes4zIaMxpMZgTEw083m+3PIGHnxqflZhVJG2FdImPWXCfdOMHhGbzaDwkWbOWt+1G6XryDnjOwjW/X5TC/JFyN5fAUiJNj+NF8Nt5GRQnSw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787327387; c=relaxed/simple; bh=68rweg3KUBNtNCRd8zE5NMygPE+Q+TF5sbt6T5BIiG8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iVbXHpOdghHvYFEBprIlW3NvOPct6MdfWvZaaIJDTv3xrpoSWAH5P5qZpqpWOuLrARqy6aZJaysOg6ZC3q7hMl2TE42cl6NJKLTAVAKuyb680d6MP0pKDmA4P+O6c/fMPbKKh6NQw2LNTSNF2XV3UN1RHymE0Y9U/3hcvVxHqXA= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=V5SCUTZa reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 955C24BAE7F3 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id xMmmwJ7iWusRSxRV4wH980; Fri, 21 Aug 2026 15:49:46 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xRV3wZxjmfUXOxRV4wybDE; Fri, 21 Aug 2026 15:49:46 +0000 X-Authority-Analysis: v=2.4 cv=OaaYDgTY c=1 sm=1 tr=0 ts=6a88739a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=pGLkceISAAAA:8 a=7z6GGnf-pOQk6qP1qV8A:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+gIgz6zcsItPrWNcMHoLOw1v43Puizx7G6RsMu10Be0=; b=V5SCUTZaNilnTzl1DWvkIdCuIz JgIa3oDP9cGCoWuzcO0vtw/DIechxFlmRs+VjGlfVknpXtDDwT9QMUpHd2Ct/mRnRq4pn2nequUsa PM53usQk0mQQ9QqFdtmdrbgcO; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:43434 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wxRV3-00000000AlK-1fwM; Fri, 21 Aug 2026 09:49:45 -0600 From: Tom Tromey To: Oleg Tolmatcev Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/dap: stop setting CompletionItem.length In-Reply-To: <20260801160233.79-2-oleg.tolmatcev@gmail.com> (Oleg Tolmatcev's message of "Sat, 1 Aug 2026 18:02:34 +0200") References: <20260801160233.79-2-oleg.tolmatcev@gmail.com> X-Attribution: Tom Date: Fri, 21 Aug 2026 09:49:44 -0600 Message-ID: <87zeyfqxrb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1wxRV3-00000000AlK-1fwM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:43434 X-Source-Auth: tom+tromey.com X-Email-Count: 36 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfI9N3AdvrxAqlfcF+/cLtJBFdne8FB0QNDYicaNYZIeiNgvsZYMRyzyk+sMn/jBXAaByoeHCu538653ne8B3h/jTKuYYU0ghOwADPfiQlf1jctbMeMv+ kpw0P9BYWYSoW9Vz8kvVcV3RPAs6GjU0hmGi9sdCT72QsEgE7NEpVPv11yjaBHZNQD6zyujF3E9nhqMzE9UVSHPEs4GsicneIM0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Oleg" == Oleg Tolmatcev writes: Oleg> Do not set the CompletionItem.length field in completions responses. Oleg> According to the DAP spec, length says how many characters the Oleg> completion text should overwrite. It is not the length of the Oleg> completion label, so using the label length here is wrong. I am not so sure about this. The spec says: /** * Length determines how many characters are overwritten by the completion * text and it is measured in UTF-16 code units. If missing the value 0 is * assumed which results in the completion text being inserted. */ length?: number; But IIUC the gdb 'completions' result will also include whatever prefix was supplied. So for instance I think if we try to complete "print" we might get results like "print_this" and "print_that". But here we wouldn't want to report length=0, because wouldn't that mean "the completion text being inserted" would result in "printprint_this" and "printprint_that"? Tom