From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13192 invoked by alias); 28 Feb 2012 22:46:48 -0000 Received: (qmail 13179 invoked by uid 22791); 28 Feb 2012 22:46:46 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Feb 2012 22:46:32 +0000 Received: from nat-dem.mentorg.com ([195.212.93.2] helo=eu2-mail.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1S2VoU-00041h-82 from Thomas_Schwinge@mentor.com ; Tue, 28 Feb 2012 14:46:30 -0800 Received: from feldtkeller.schwinge.homeip.net ([172.30.64.109]) by eu2-mail.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 28 Feb 2012 23:46:28 +0100 From: Thomas Schwinge To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Kevin Buettner Subject: Re: Testsuite regression for annota1.exp and annota3.exp [Re: [PATCH] [SH] ... can do this signal stuff!] In-Reply-To: <20120228194137.GA947@host2.jankratochvil.net> References: <874nub5n16.fsf@schwinge.name> <20120228160351.GA12029@host2.jankratochvil.net> <871upe6aj5.fsf@schwinge.name> <20120228194137.GA947@host2.jankratochvil.net> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Tue, 28 Feb 2012 23:27:00 -0000 Message-ID: <87y5rm4lvo.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00684.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1028 Hi! On Tue, 28 Feb 2012 20:41:37 +0100, Jan Kratochvil wrote: > On Tue, 28 Feb 2012 20:08:30 +0100, Thomas Schwinge wrote: > > 142db50201b1b1c69ebdc2dcdb1181cde1db3b08 I got the idea of using [concat > > ...] for building gdb_expect_list's third list argument -- it needs to > > expand $main_line, etc. Any better suggestions (I obviously don't have= a > > lot of TCL and/or GDB testcase writing experience), or is this > > acceptable? >=20 > I find it OK. Thanks for reviewing this quickly. > Please edit in your patch: > > + "Breakpoint.*at.* file .*$srcfile, line $main_line\." \ > -> > + "Breakpoint.*at.* file .*$srcfile, line $main_line\\." \ >=20 > (as \. is just TCL character . and regex then just gets ., not \.) Makes sense; re-tested and then committed with that change. There are, of course, other similar inaccuracies, such as an unquoted dot after expanding $srcfile in the line that you quoted above, but that's a separate cleanup project. Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 489 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJPTVk7AAoJENuKOtuXzphJK4cH/3RYUagXem6/peswJS9oMG+/ OX1JIqE+wC5p9jrV1z6lmI8GrRyKf7qdTU2jAdmgajcWJp6oOCRFnpzGV3OxJdpT 0a6t1ypa1jho69Fac2wSbDulveuCJpvHqA4MibMrM7AdZGwS63zhftZtBaTmdbpG 29I5yxlKjaQodqwuiKRjw8YDrX900Wvq2KlZWEaByryv0zOGEqxHOHwDbT0/oc5Z FnzE14SLSjsXGx+KAlc1ABN+Rezr7k8ltH0KWtRQh4c/ArrniQoxGZE8wPQE8+t6 16yxwwxxx2LiVqqp6Vz9DhqmJixHXrPgE2SXlMzI3743aMGc2aKI/YRbU1BxwjE= =YZ8r -----END PGP SIGNATURE----- --=-=-=--