From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: "Maciej W. Rozycki" <macro@codesourcery.com>,
Daniel Jacobowitz <drow@false.org>,
gdb-patches@sourceware.org,
Richard Sandiford <rdsandiford@googlemail.com>
Subject: Re: gdb_test_multiple and empty $message
Date: Thu, 26 Apr 2012 14:31:00 -0000 [thread overview]
Message-ID: <87y5pi8tnm.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4F99491E.8050605@redhat.com> (Pedro Alves's message of "Thu, 26 Apr 2012 14:09:50 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> My impression gdb_test without a message string is used at places
Pedro> we're sending some commands that just prepare the real test.
Pedro> It's a bit arguable whether we should do that, but there you go.
Pedro> But I think that hiding an internal fail in such preparation
Pedro> steps, which are never ever expected to fail (otherwise you'd
Pedro> pass down a message string to begin with) would be actively
Pedro> harmful, and make it harder to grok and debug testsuite results.
Yeah, I agree.
I remember thinking sometimes that it would be nice to have something
like gdb_test_multiple that just returns a status instead of also
logging a pass/fail as a side effect. I can't remember my scenario now.
Pedro> So I suggest just removing the dead empty string tests from
Pedro> gdb_test_multiple, making the non-empty paths unconditional.
Yes please.
Tom
next prev parent reply other threads:[~2012-04-26 14:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 22:36 [RFA] MIPS/GDB: Fix the handling of MIPS16 thunks Maciej W. Rozycki
2012-04-11 19:16 ` Richard Sandiford
2012-04-12 13:09 ` Maciej W. Rozycki
2012-04-12 19:39 ` Richard Sandiford
2012-04-13 20:46 ` Maciej W. Rozycki
2012-04-20 14:54 ` Pedro Alves
2012-04-20 16:01 ` Maciej W. Rozycki
2012-04-21 18:55 ` Daniel Jacobowitz
2012-04-26 0:10 ` Maciej W. Rozycki
2012-04-26 13:10 ` Pedro Alves
2012-04-26 17:27 ` Maciej W. Rozycki
2012-04-26 13:23 ` gdb_test_multiple and empty $message Pedro Alves
2012-04-26 13:34 ` Pedro Alves
2012-04-26 14:31 ` Tom Tromey [this message]
2012-04-26 14:42 ` Joel Brobecker
2012-04-27 20:23 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5pi8tnm.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
--cc=palves@redhat.com \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox