From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7243 invoked by alias); 24 Jul 2012 20:40:32 -0000 Received: (qmail 7235 invoked by uid 22791); 24 Jul 2012 20:40:31 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Jul 2012 20:40:18 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6OKeFwu024014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 24 Jul 2012 16:40:15 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6OKeE8l025788 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 24 Jul 2012 16:40:14 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 2/6] allow to suppress more mi notification References: <1343146252-22558-1-git-send-email-yao@codesourcery.com> <1343146252-22558-3-git-send-email-yao@codesourcery.com> Date: Tue, 24 Jul 2012 20:40:00 -0000 In-Reply-To: <1343146252-22558-3-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Wed, 25 Jul 2012 00:10:48 +0800") Message-ID: <87y5m8nb9t.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00505.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2012-07-24 Yao Qi Yao> * mi/mi-interp.c: Remove mi_suppress_breakpoint_notifications. Yao> Define array mi_suppress_notification. Yao> (mi_breakpoint_created): Update. Yao> (mi_breakpoint_deleted): Likewise. Yao> (mi_breakpoint_modified): Likewise. Yao> * mi/mi-main.c (mi_cmd_execute): Likewise. Yao> * mi/mi-main.h (enum MI_SUPRESS_NOTIFICATION): New. Looks pretty good. One nit... Yao> +enum MI_SUPRESS_NOTIFICATION { MI_SUPPRESS_BREAKPOINT }; It is odd to use all caps for an enum tag name. Ok with this changed. Tom