From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-95300-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15722 invoked by alias); 18 Oct 2012 01:13:36 -0000
Received: (qmail 15712 invoked by uid 22791); 18 Oct 2012 01:13:35 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Oct 2012 01:13:26 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9I1DNtD009543	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 17 Oct 2012 21:13:23 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9I1DKGS008222	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 17 Oct 2012 21:13:21 -0400
From: Tom Tromey <tromey@redhat.com>
To: lgustavo@codesourcery.com
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix mi "-var-create" regression
References: <5075D4FD.9050900@mentor.com> <20121014171805.GB3050@adacore.com>	<507BFF97.2000900@codesourcery.com>
Date: Thu, 18 Oct 2012 01:13:00 -0000
In-Reply-To: <507BFF97.2000900@codesourcery.com> (Luis Machado's message of	"Mon, 15 Oct 2012 09:20:39 -0300")
Message-ID: <87y5j4ziof.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-10/txt/msg00308.txt.bz2

>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:

Luis> +	  && TYPE_CODE (TYPE_TARGET_TYPE (result)) != TYPE_CODE_VOID)

On further reflection, I have a question and a comment.

First, perhaps instead of excluding void* here, we should only allow
pointers to structs.  That is the only case that has RTTI anyhow.  What
do you think?

Also, I think this needs a check_typedef around TYPE_TARGET_TYPE.

Tom