From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9821 invoked by alias); 22 Oct 2012 20:45:46 -0000 Received: (qmail 9766 invoked by uid 22791); 22 Oct 2012 20:45:45 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Oct 2012 20:45:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9MKjau9010789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 22 Oct 2012 16:45:36 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9MKjZUt006447 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 22 Oct 2012 16:45:35 -0400 From: Tom Tromey To: Siddhesh Poyarekar Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded References: <20120927190053.1e7de264@spoyarek> <20120929173938.GA2987@host2.jankratochvil.net> <20120929181141.GA4009@host2.jankratochvil.net> <20120930065211.GA21118@host2.jankratochvil.net> <20121003184155.03dceed4@spoyarek> <20121003195627.GA17283@host2.jankratochvil.net> <20121004071314.GA4292@host2.jankratochvil.net> <20121021130546.02ea680c@spoyarek> Date: Mon, 22 Oct 2012 20:45:00 -0000 In-Reply-To: <20121021130546.02ea680c@spoyarek> (Siddhesh Poyarekar's message of "Sun, 21 Oct 2012 13:05:46 +0530") Message-ID: <87y5iygrrk.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00387.txt.bz2 >>>>> "Siddhesh" == Siddhesh Poyarekar writes: Siddhesh> Here is a fix on top of the bitpos fixes based on the warnings Siddhesh> generated from gcc -Wconversion. I have also attached the Siddhesh> report for review; I have not rebased since the last Siddhesh> submission to ensure that the line numbers don't go awry. Most Siddhesh> of the extra warnings were either unrelated or were the length Siddhesh> parameter to (store|extract)_(un)?signed_integer functions Siddhesh> that are safe. Siddhesh> I have also verified that this does not cause any regressions in the Siddhesh> testsuite and that the gcc warnings generated after this were safe. IIUC, this patch fixes some subset of -Wconversion warnings but leaves the rest untouched. Would it be very hard or ugly if we just tried to fix them all, and then enabled -Wconversion in configure? Aside from maybe some code ugliness, I wonder what the downsides would be. The reason I ask is that I'm concerned about our ability to maintain this change properly, and I wonder if this would be a cheap way to handle the more mechanical aspects. Tom