From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32383 invoked by alias); 13 May 2013 14:59:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32374 invoked by uid 89); 13 May 2013 14:59:33 -0000 X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_EG autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 13 May 2013 14:59:32 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4DExVhQ000593 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 13 May 2013 10:59:31 -0400 Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4DExTR1018363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 13 May 2013 10:59:30 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 39/40] fix compile_rx_or_error References: <519055B5.10803@codesourcery.com> Date: Mon, 13 May 2013 14:59:00 -0000 In-Reply-To: <519055B5.10803@codesourcery.com> (Yao Qi's message of "Mon, 13 May 2013 10:53:41 +0800") Message-ID: <87y5bjc4dq.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00439.txt.bz2 >>>>> "Yao" == Yao Qi writes: >> - if (!rx) >> - return NULL; >> - Yao> Do we need an assert on RX here? It can't hurt, but I think the subsequent regcomp will just crash. I will add one. Tom