From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-104843-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5213 invoked by alias); 30 Aug 2013 16:26:10 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 5204 invoked by uid 89); 30 Aug 2013 16:26:10 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Aug 2013 16:26:10 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7UGQ6td000951	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 30 Aug 2013 12:26:06 -0400
Received: from barimba (ovpn-113-142.phx2.redhat.com [10.3.113.142])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r7UGQ49B000418	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 30 Aug 2013 12:26:05 -0400
From: Tom Tromey <tromey@redhat.com>
To: "Andrew Burgess" <aburgess@broadcom.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb.base/code_elim.exp - empty bss issue.
References: <5220B60D.2090807@broadcom.com>
Date: Fri, 30 Aug 2013 16:26:00 -0000
In-Reply-To: <5220B60D.2090807@broadcom.com> (Andrew Burgess's message of	"Fri, 30 Aug 2013 16:11:09 +0100")
Message-ID: <87y57jm9gj.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-08/txt/msg00937.txt.bz2

>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:

Andrew> I could fix this by either:
[...]
Andrew>   3. Force the test to generate some .bss content.

Andrew> I chose option #3 but would be happy to rewrite to any of the other
Andrew> options if they were prefered.

I think your choice is fine.

Andrew> 2013-08-30  Andrew Burgess  <aburgess@broadcom.com>
Andrew> 	* gdb.base/code_elim1.c (my_bss_symbol): New variable added.
Andrew> 	(my_static_symbol): Add comment.
Andrew> 	(main): Reference my_bss_symbol.

Ok.

Tom