Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: Sanimir Agovic <sanimir.agovic@intel.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] python: disallow python code to instanciate certain types
Date: Thu, 10 Oct 2013 19:08:00 -0000	[thread overview]
Message-ID: <87y56154gq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5220B578.6030100@redhat.com> (Phil Muldoon's message of "Fri, 30	Aug 2013 16:08:40 +0100")

>> -static PyObject *
>> -objfpy_new (PyTypeObject *type, PyObject *args, PyObject *keywords)
[...]

Phil> In removing this function, you are removing the instantiation of
Phil> self-> printers (Which is needed for pretty-printers),
Phil> self-> frame-filters (for frame filters) and self->type_printers (for
Phil> type printers).  If this is the case, and I have not missed an
Phil> equivalent instantiation somewhere else, you will have an
Phil> uninitialized PyObject for each of the above and likely will result in
Phil> a crash?

Internal instantiations don't go through tp_new.  instead they use
PyObject_New.

In the case of objfile these fields are initialized in
objfile_to_objfile_object.

>> -static PyObject *
>> -pspy_new (PyTypeObject *type, PyObject *args, PyObject *keywords)

Phil> Ditto, same with object files above.

This is handled in pspace_to_pspace_object.

Tom


  reply	other threads:[~2013-10-10 19:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30 14:40 [PATCH 0/2] prevent gdb.Frame/Objfile and other types to be instanciated Sanimir Agovic
2013-08-30 14:40 ` [PATCH 1/2] python: disallow python code to instanciate certain types Sanimir Agovic
2013-08-30 15:08   ` Phil Muldoon
2013-10-10 19:08     ` Tom Tromey [this message]
2013-10-10 19:06   ` Tom Tromey
2013-08-30 14:40 ` [PATCH 2/2] test: ensure certain types exposed to python are not instancable Sanimir Agovic
2013-10-10 19:14   ` Tom Tromey
2013-10-10 19:59     ` Paul_Koning
2013-10-10 19:10 ` [PATCH 0/2] prevent gdb.Frame/Objfile and other types to be instanciated Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y56154gq.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    --cc=sanimir.agovic@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox