From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-108861-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3236 invoked by alias); 6 Jan 2014 16:48:52 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 3227 invoked by uid 89); 6 Jan 2014 16:48:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2014 16:48:51 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s06Gmi6h010158	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 6 Jan 2014 11:48:44 -0500
Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s06GmfpW031289	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 6 Jan 2014 11:48:42 -0500
From: Tom Tromey <tromey@redhat.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Yao Qi <yao@codesourcery.com>, GDB Patches <gdb-patches@sourceware.org>,        Joel Brobecker <brobecker@adacore.com>,        Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [PATCH] Cast to uintptr_t when calling ptrace32 on aix
References: <CAGWvnykbAX1aY+qeXT0GR6rBevK6ao2Us9nt4UmwUvtdzkbK1A@mail.gmail.com>	<52CA02FE.6060804@codesourcery.com>	<CAGWvny=aCO=myEqvYJV4LmyPArdzSBRZYc7RExS7Ga4uL-hx_A@mail.gmail.com>
Date: Mon, 06 Jan 2014 16:48:00 -0000
In-Reply-To: <CAGWvny=aCO=myEqvYJV4LmyPArdzSBRZYc7RExS7Ga4uL-hx_A@mail.gmail.com>	(David Edelsohn's message of "Sun, 5 Jan 2014 20:21:01 -0500")
Message-ID: <87y52tnjiu.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2014-01/txt/msg00063.txt.bz2

>>>>> "David" == David Edelsohn <dje.gcc@gmail.com> writes:

David> I meant it would be nice to encapsulate this in one file instead of
David> defining ptrace32, ptrace64, ptracex, etc. multiple times in multiple
David> files. It appears that you are performing the same cast as Joel, so it
David> should be correct. It would be nice to use a consistent syntax. But it
David> would be even nicer to do this only once.

Yeah, I agree.  IIRC we've run into this in another spot as well.

Tom