From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-109487-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3527 invoked by alias); 18 Jan 2014 02:32:19 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 3518 invoked by uid 89); 18 Jan 2014 02:32:18 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 18 Jan 2014 02:32:18 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0I2WFDu008823	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 17 Jan 2014 21:32:15 -0500
Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0I2WEsg020113	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 17 Jan 2014 21:32:14 -0500
From: Tom Tromey <tromey@redhat.com>
To: Roland McGrath <mcgrathr@google.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: Support install-strip target
References: <CAB=4xhqkKyNaXr2MH6i2Uu6=15akmp6WLtfVZ1Uw6q+=o2sshw@mail.gmail.com>
Date: Sat, 18 Jan 2014 02:32:00 -0000
In-Reply-To: <CAB=4xhqkKyNaXr2MH6i2Uu6=15akmp6WLtfVZ1Uw6q+=o2sshw@mail.gmail.com>	(Roland McGrath's message of "Thu, 16 Jan 2014 16:38:00 -0800")
Message-ID: <87y52ej9zm.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2014-01/txt/msg00689.txt.bz2

>>>>> "Roland" == Roland McGrath <mcgrathr@google.com> writes:

Roland> This makes gdb support the install-strip target, which all the other
Roland> binutils subdirs that are automake-driven already support.  I just
Roland> copied the automake-generated logic.

Roland> OK for trunk and 7.7 branch?

My only question is what happens when install -s is run on 'gcore',
which is a shell script; I don't remember if install is smart about this
or not.  I think automake defines a separate INSTALL_SCRIPT to handle
this.

If that works ok, this patch is fine.
Otherwise a bit more is needed.

Tom