Re: [PATCH 3/7] Include alloca.h unconditionally

Pedro Alves
2014-11-21T13:17:18Z

On 11/21/2014 01:05 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>>> -#ifdef HAVE_ALLOCA_H
>>> -#include <alloca.h>
>>> -#endif
>>> /* On some systems such as MinGW, alloca is declared in malloc.h
>>> (there is no alloca.h). */
>>> #if HAVE_MALLOC_H
>>
>> We should remove the malloc.h includes too then, and the check
>> for malloc.h in configure.ac. It's only included for alloca.
>
> That is a good point. The patch below is to do so.

Thanks. This version looks good to me.

Pedro Alves