Re: [PATCH] Provide useful completer for "info registers"

[Andreas Arnez <arnez@linux.vnet.ibm.com>]

On Thu, Dec 04 2014, Pedro Alves wrote:

> Also, ...
>
> On 11/25/2014 05:28 PM, Andreas Arnez wrote:
>> +    for (i = 0; i < n_regs; i++)
>> +      {
>> +	const char *reg_name = gdbarch_register_name (gdbarch, i);
>> +
>> +	if (reg_name != NULL && strncmp (text, reg_name, len) == 0)
>> +	  VEC_safe_push (char_ptr, result, xstrdup (reg_name));
>
> Not sure under which conditions "len" could be zero here.  If it may,
> note that some registers have empty names.  See default_print_registers_info:
>
>       /* If the register name is empty, it is undefined for this
>          processor, so don't display anything.  */
>       if (gdbarch_register_name (gdbarch, i) == NULL
> 	  || *(gdbarch_register_name (gdbarch, i)) == '\0')
> 	continue;
>
>> +      }
>> +  }

Good point.  This is fixed in the new version; registers with empty
names are skipped now.