From: Andy Wingo <wingo@igalia.com>
To: Doug Evans <dje@google.com>
Cc: Alexander Smundak <asmundak@google.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: Unwinding through multiple stacks
Date: Wed, 25 Mar 2015 07:35:00 -0000 [thread overview]
Message-ID: <87y4ml1qcy.fsf@igalia.com> (raw)
In-Reply-To: <CADPb22ROU+XoYhNhRqLWJycC43nuk9m15GEE3o7f_y_Oie8EzQ@mail.gmail.com> (Doug Evans's message of "Tue, 24 Mar 2015 17:00:07 -0700")
Hi,
On Wed 25 Mar 2015 01:00, Doug Evans <dje@google.com> writes:
> A topic came up on #gdb that the current patches don't cover.
> What if the frame we're trying to unwind through has a different
> stack?
I was wondering about this too. IIUC this check from GDB isn't a
fundamental limitation -- it's just a convenience for the user, that we
don't keep trying to compute outer frames for what looks to be a corrupt
stack.
In these cases I would have the unwinder mark the frame as not needing
an UNWIND_INNER_ID check. Having the check by default is still useful
IMO. How about
(unwind-info-set-discontiguous! unwind-info #t)
or something. That would eventually cause the frame_id to have a
"discontiguous" bitfield marked as 1.
To me it seems appropriate for a followup patch. WDYT?
Andy
prev parent reply other threads:[~2015-03-25 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 0:00 Doug Evans
2015-03-25 7:35 ` Andy Wingo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4ml1qcy.fsf@igalia.com \
--to=wingo@igalia.com \
--cc=asmundak@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox