From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95572 invoked by alias); 22 Apr 2017 16:20:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95533 invoked by uid 89); 22 Apr 2017 16:20:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Apr 2017 16:20:09 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8076116181; Sat, 22 Apr 2017 16:20:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8076116181 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8076116181 Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4921D7D4EE; Sat, 22 Apr 2017 16:20:06 +0000 (UTC) From: Sergio Durigan Junior To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [patch+8.0] release branch: Fix: --enable-werror In-Reply-To: <20170421085204.GA5501@host1.jankratochvil.net> (Jan Kratochvil's message of "Fri, 21 Apr 2017 10:52:04 +0200") References: <20170421085204.GA5501@host1.jankratochvil.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Date: Sat, 22 Apr 2017 16:20:00 -0000 Message-ID: <87y3usv2h5.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00627.txt.bz2 On Friday, April 21 2017, Jan Kratochvil wrote: > Hi, > > gdb-8.0-branch > ./configure --enable-werror --enable-targets=3Dall > aarch64-tdep.c:3045:13: error: =E2=80=98void selftests::aarch64_process_r= ecord_test()=E2=80=99 declared =E2=80=98static=E2=80=99 but never defined [= -Werror=3Dunused-function] > arm-tdep.c:9601:13: error: =E2=80=98void selftests::arm_record_test()=E2= =80=99 declared =E2=80=98static=E2=80=99 but never defined [-Werror=3Dunuse= d-function] > > OK for check-in? > > Please do not tell me release branches do not support --enable-werror as = this > is due to a sourcebase bug, not due to some unexpected compiler > incompatibility. > > Sergio: Shouldn't it be also buildbot-tested? Yes, it should. We have an Arch64 builder managed by Yao. It should be possible to set up builders for the 8.0 branch. > Jan > > gdb/ChangeLog > 2017-04-21 Jan Kratochvil > > * aarch64-tdep.c (selftests::aarch64_process_record_test): Make it #if > GDB_SELF_TEST. > * arm-tdep.c (selftests::arm_record_test): Likewise. > > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index 28c2573..6113621 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -3040,10 +3040,12 @@ aarch64_dump_tdep (struct gdbarch *gdbarch, struc= t ui_file *file) > paddress (gdbarch, tdep->lowest_pc)); > } >=20=20 > +#if GDB_SELF_TEST > namespace selftests > { > static void aarch64_process_record_test (void); > } > +#endif >=20=20 > /* Suppress warning from -Wmissing-prototypes. */ > extern initialize_file_ftype _initialize_aarch64_tdep; > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index c8fabfb..9ac667f 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -9596,10 +9596,12 @@ arm_dump_tdep (struct gdbarch *gdbarch, struct ui= _file *file) > (unsigned long) tdep->lowest_pc); > } >=20=20 > +#if GDB_SELF_TEST > namespace selftests > { > static void arm_record_test (void); > } > +#endif >=20=20 > extern initialize_file_ftype _initialize_arm_tdep; /* -Wmissing-prototyp= es */ >=20=20 > --=20 Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/