From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4538 invoked by alias); 13 Sep 2017 23:00:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4526 invoked by uid 89); 13 Sep 2017 22:59:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1283 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Sep 2017 22:59:58 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DE4C98553C; Wed, 13 Sep 2017 22:59:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DE4C98553C Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B4B1B60C8A; Wed, 13 Sep 2017 22:59:56 +0000 (UTC) From: Sergio Durigan Junior To: Eli Zaretskii Cc: gdb-patches@sourceware.org, palves@redhat.com Subject: Re: [PATCH 3/4] Introduce gdb_chdir References: <20170912042325.14927-1-sergiodj@redhat.com> <20170912042325.14927-4-sergiodj@redhat.com> <83h8w8q87m.fsf@gnu.org> Date: Wed, 13 Sep 2017 23:00:00 -0000 In-Reply-To: <83h8w8q87m.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Sep 2017 17:53:33 +0300") Message-ID: <87y3pixl03.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00368.txt.bz2 On Tuesday, September 12 2017, Eli Zaretskii wrote: >> From: Sergio Durigan Junior >> Cc: Pedro Alves , Sergio Durigan Junior >> Date: Tue, 12 Sep 2017 00:23:24 -0400 >> >> In order to be able to change the inferior's directory before its >> execution, it is necessary to perform a tilde expansion of the >> directory provided by the user and then chdir into the resulting dir. >> This is what gdb_chdir does. >> >> Unfortunately it is not possible to use "tilde_expand" from readline >> because this is common code and gdbserver doesn't use readline. For >> that reason I decided to go with "glob" and its GNU extension, >> GLOB_TILDE. With the import of the "glob" module from gnulib, this is >> a no-brainer. > > Why not simply 'getenv("HOME")'? Tilde expansion can be more complicated than that. If you're just using "~/test", then yeah, you can use $HOME. However, the user can specify a directory like "~someone/test", and in that case you have to where is "someone's $HOME" before you can expand the tilde. glob takes care of that for us. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/