From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54231 invoked by alias); 22 Sep 2017 20:24:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54217 invoked by uid 89); 22 Sep 2017 20:24:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 20:24:28 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5AA1D806CC; Fri, 22 Sep 2017 20:24:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5AA1D806CC Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 328FD5EE02; Fri, 22 Sep 2017 20:24:27 +0000 (UTC) From: Sergio Durigan Junior To: Eli Zaretskii Cc: gdb-patches@sourceware.org, palves@redhat.com Subject: Re: [PATCH v3 4/5] Implement "set cwd" command on GDB References: <20170912042325.14927-1-sergiodj@redhat.com> <20170921225926.23132-1-sergiodj@redhat.com> <20170921225926.23132-5-sergiodj@redhat.com> <83poajcg9a.fsf@gnu.org> <878th64nqk.fsf@redhat.com> <838th6d0l1.fsf@gnu.org> Date: Fri, 22 Sep 2017 20:24:00 -0000 In-Reply-To: <838th6d0l1.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 22 Sep 2017 21:56:10 +0300") Message-ID: <87y3p6zdl1.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00697.txt.bz2 On Friday, September 22 2017, Eli Zaretskii wrote: >> From: Sergio Durigan Junior >> Cc: gdb-patches@sourceware.org, palves@redhat.com >> Date: Fri, 22 Sep 2017 14:00:51 -0400 >> >> On Friday, September 22 2017, Eli Zaretskii wrote: >> >> >> +@kindex set cwd >> >> +@cindex change inferior's working directory >> >> +@item set cwd @r{[}@var{directory}@r{]} >> >> +Set the inferior's working directory to @var{directory}. If not >> >> +given, @var{directory} uses @file{'~'}. >> > >> > I think we should document here what does "~" mean on MS-Windows, >> > especially since, when HOME is not in the environment, Gnulib's glob >> > module doesn't behave according to MS platform recommendations (which >> > say not to create files directly below %HOMEDRIVE%%HOMEPATH%). >> >> Sure, but just to be clear, this text was strongly based on another part >> of the docs, which also mentions '~' without explaining further. >> >> As I am totally out of the loop when it comes to Windows environments, >> I'd appreciate a suggestion for the new text. > > If you write the Unix part, I can propose how to amend it to cover > Windows. OK? Deal. Thanks. >> > This seems to pass the unexpanded cwd directly to CreateProcess. I >> > don't think this will work on Windows, as this directory is not >> > interpreted by any shell, so "~" will cause errors. I think we should >> > pass this via gdb_tilde_expand, like we do in the Unix case, and I >> > also think we should mirror all the slashes in the result, just in >> > case. >> >> Hm, you're right. I will call "gdb_tilde_expand" here. I'm not sure >> what you mean by "mirror all the slashes in the result". Do you mean >> "escape the slashes"? > > No, I mean convert forward slashes to backslashes. Sorry, I wasn't familiar with the term. Anyway, I think I can implement that. In fact, I think gdbserver/win32-low.c:create_process already does that, right? wprogram = alloca ((strlen (program) + 1) * sizeof (wchar_t)); mbstowcs (wprogram, program, strlen (program) + 1); for (p = wprogram; *p; ++p) if (L'/' == *p) *p = L'\\'; Anyway, I'll do the same for the inferior's cwd. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/