From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52886 invoked by alias); 14 Jun 2018 19:50:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52754 invoked by uid 89); 14 Jun 2018 19:50:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=D*polymtl.ca, simonmarchipolymtlca, simon.marchi@polymtl.ca, our X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.152.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Jun 2018 19:50:34 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 9B06818CEC for ; Thu, 14 Jun 2018 14:50:32 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id TYGDfEFmibXuJTYGKfRyye; Thu, 14 Jun 2018 14:50:32 -0500 X-Authority-Reason: nr=8 Received: from [12.176.89.6] (port=35618 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fTYGD-001gH5-0k; Thu, 14 Jun 2018 14:50:21 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] default_type_align: Use type_length_units References: <1528928623-27479-1-git-send-email-simon.marchi@ericsson.com> <877en1e23t.fsf@tromey.com> Date: Thu, 14 Jun 2018 19:50:00 -0000 In-Reply-To: (Simon Marchi's message of "Thu, 14 Jun 2018 14:25:49 -0400") Message-ID: <87y3fhcflw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fTYGD-001gH5-0k X-Source-Sender: (pokyo) [12.176.89.6]:35618 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-06/txt/msg00373.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> This use seems related to C++, and our compiler is C only, so I can't Simon> test that. But it would make sense, I can include that change if you Simon> prefer. Yeah, I think it would be best to either change both or change neither (and update the comment). Tom