From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72045 invoked by alias); 30 Aug 2018 02:19:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72027 invoked by uid 89); 30 Aug 2018 02:19:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=heard, H*f:sk:87lg8q7, H*f:sk:eaa6d3a, H*f:sk:1535225 X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.150.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Aug 2018 02:19:35 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 3A174468225 for ; Wed, 29 Aug 2018 21:19:34 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vCYYffhp9PvAdvCYYfczRv; Wed, 29 Aug 2018 21:19:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SpaeqgCK7PanxrxJiHAg+spDU0CJCOZQAnjZxfJo0jY=; b=mY/o6TVAEmf2RY3rooag361G80 gJj88PDDLvtp1hnWCEcKRqobpohognSy7GZF/KzvCYZNeWFTKx4O2MbJFKknm1vITCSB+sZIGB54l skR2R/jsC3u0YhG7LNbFSeANb; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:49652 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fvCYX-000MnD-TM; Wed, 29 Aug 2018 21:19:33 -0500 From: Tom Tromey To: Andrew Burgess Cc: Philippe Waroquiers , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: Allow parenthesis to group arguments to user-defined commands References: <1535225533.1438.5.camel@skynet.be> <1535230403.1438.10.camel@skynet.be> <20180825224310.GA32506@embecosm.com> <87lg8q7ai7.fsf@tromey.com> <20180828184331.GJ32506@embecosm.com> <1535488137.7778.4.camel@skynet.be> <20180828232948.GK32506@embecosm.com> Date: Thu, 30 Aug 2018 02:19:00 -0000 In-Reply-To: <20180828232948.GK32506@embecosm.com> (Andrew Burgess's message of "Wed, 29 Aug 2018 00:29:49 +0100") Message-ID: <87y3covbnv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00797.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> In general I'm happy to rework this part of GDB, but ideally I'd like Andrew> some feedback from a global maintainer that such a change, which might Andrew> would break backward compatibility, would be acceptable... My philosophy has generally been to avoid incompatibility when possible and when there seems to be some likelihood that the behavior is actually used. So, for example, I felt ok changing the parsing of "bt" arguments, because I felt the implementation was simply buggy and that nobody would be using its weird corner cases. On the other hand, back in the day I changed the parsing of "disassemble" and heard complaints for quite some time. I guess this informed my view. Sometimes this leads to bad results, like how users should nearly always use "watch -location", but it isn't the default. This is why I think the paren grouping idea is fine: the examples I can think of all seem useless. That said, upthread you mentioned the idea of passing a flag to "define" to change how arguments are parsed. I would be ok with this as well. However I think that in this case it would be good to work out the details beforehand, including looking through bugzilla to see if there are other unmet needs. Tom