From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94081 invoked by alias); 14 Sep 2018 12:46:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94066 invoked by uid 89); 14 Sep 2018 12:46:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Sep 2018 12:46:06 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 36E4B6781F for ; Fri, 14 Sep 2018 07:46:05 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 0nTygR1AJPvAd0nU1gLNoa; Fri, 14 Sep 2018 07:46:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fOpe0/oHmRkJaJL0d4teOafv6vJH2lUpURctCdgDBgQ=; b=b/nbBwM/EBGYDwNU3v7jTWhDp+ kNyidjaK7poZfVje++xu1NkSxOrgXSDgCdJZnc2a7RvVpVv4u+gifrfuolqasLIL3gzQdjZu+nDlQ MnxsukUOue2c6toZ7/37gsJSD; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:39822 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g0nTx-002TRm-V9; Fri, 14 Sep 2018 07:45:58 -0500 From: Tom Tromey To: Sergio Durigan Junior Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Remove variable in get_startup_shell non-static References: <20180913223416.12824-1-tom@tromey.com> <87k1npotux.fsf@redhat.com> Date: Fri, 14 Sep 2018 12:46:00 -0000 In-Reply-To: <87k1npotux.fsf@redhat.com> (Sergio Durigan Junior's message of "Thu, 13 Sep 2018 19:33:42 -0400") Message-ID: <87y3c42qnu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00453.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> IIRC this code was added by a patch of mine. I think your patch makes Sergio> sense. Perhaps, since the SHELL can't change once you start GDB, this Sergio> function could be made a bit smarter and check whether "ret" has been Sergio> initialized or not (in order to call "getenv" just once), but really, Sergio> that's not necessary at all, and your patch is totally fine. Thanks, I'm going to check it in. Tom