Re: [PATCH v2] Implement timestamp'ed output on "make check"

Simon Marchi
2018-11-26T17:22:51Z

On 2018-11-26 11:29, Sergio Durigan Junior wrote:

>>> And FWIW, I don't really like this part of PEP8 which
>>> states that there should be no spaces before parentheses.
>>
>> If you hate it that much, feel free to propose a change to our
>> standards :)
>
> Sorry if it appeared that I was complaining about your email! Not my
> intention at all, and I do appreciate your reviews.

No harm felt on this side, my response could be interpreted a bit
harshly too, sorry about that.

> As for proposing a change to the standards... that's a good idea!
> I've
> played a little bit with "autopep8" here, and it seems to be a nice
> little tool which offers the possibility of ignoring parts of the PEP8
> spec when fixing the file. For example, for the specific case of
> "whitespace before '('", if you do:
>
> autopep8 --ignore E211 -i FILE
>
> It will not fix the "issue", and will preserve the whitespaces there.
> Neat.

I think autopep8's goal is to enforce pep8 (hence the name), so you
might not be able to have it format the code in different ways (just
ignore the warnings, as you pointed out). But there might be other
Python formatting tools that are more configurable. If there's one that
works well, which we can instruct to add spaces before parentheses (to
match how we format C/C++ code), then I think it would be reasonable to
do that.

But otherwise, it just feels we are just swimming against the current,
since pep8 is recommended by the language implementation itself, and
most tools revolve around that.

> Anyway, I just wanted to document that I found a way to disable this
> specific extension. As much as I'd like us to change this specific
> thing, I'll focus on other priorities right now.

:)

Simon