From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45906 invoked by alias); 25 Mar 2019 15:14:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45537 invoked by uid 89); 25 Mar 2019 15:14:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.214) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Mar 2019 15:14:48 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 664A61F247 for ; Mon, 25 Mar 2019 10:14:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 8RJHh3o7RiQer8RJHhqUVK; Mon, 25 Mar 2019 10:14:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XQrtTvkNRkbYfhstrdHOU92Mr5rwmdMkhrNANWJoqoM=; b=NOMaBheGdkoflgMLb9E5Lz5ESR ky58PTUsFZsp9iQ0xrGskNpQ+gul4Egpujc8BrVQ5caSgJWe/5g2f2C+lm0KMtlkO6ltarTWOKBzc jj8h0LCVqdZ+T/Vu0/6leyqfW; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:54854 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h8RJH-003o8U-0g; Mon, 25 Mar 2019 10:14:47 -0500 From: Tom Tromey To: Simon Marchi Cc: Eli Zaretskii , Pedro Alves , tromey@adacore.com, gdb-patches@sourceware.org Subject: Re: Fix pressing down in the TUI (Re: [RFC 8.3 0/3] Some style fixes) References: <20190308210433.32683-1-tromey@adacore.com> <83pnr08tc8.fsf@gnu.org> <83zhq26fcw.fsf@gnu.org> <874l899nh3.fsf@tromey.com> <8336ns3uv4.fsf@gnu.org> <831s381cp5.fsf@gnu.org> <432e3aa4-a006-bace-657b-b49ec2314190@redhat.com> <83ef76ya4g.fsf@gnu.org> <9f2b679b-44e6-0228-339b-690971887214@simark.ca> <8735852e-30bc-e5c8-de20-e0511eee8132@simark.ca> Date: Mon, 25 Mar 2019 15:14:00 -0000 In-Reply-To: <8735852e-30bc-e5c8-de20-e0511eee8132@simark.ca> (Simon Marchi's message of "Sun, 24 Mar 2019 21:36:08 -0400") Message-ID: <87y353j89m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00538.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> The obvious patch would be to fetch fullname again after calling open_source_file, Simon> like so: I think this is fine, especially with a comment explaining it. Simon> ... but maybe there's a better way? Should we instead create a Simon> local copy of FULLNAME? Ideally we'd rewrite this whole area. I don't much like stashing the full name in the symtab, and also it seems to me that gdb calls open, etc, far too much. Tom