Re: [PATCH 20/24] Make "frame apply" support -OPT options

Pedro Alves
2019-05-29T15:25:21Z

On 5/29/19 4:13 PM, Pedro Alves wrote:
> On 5/25/19 9:12 PM, Philippe Waroquiers wrote:

>>> -# Run the print integration tests.
>>> -test-print ""
>>> +# Run the print integration tests, both as "standalone", and under
>>> +# "frame apply". The latter checks that the "frame apply ... COMMAND"
>>> +# commands recurse the completion machinery for COMMAND completion
>> Not very clear what commands (with s) we speak about here ...
>>
>
> I meant all of "frame apply COUNT|level|all", which are implemented
> as separate commands. I've changed it like this:
>
> # Run the print integration tests, both as "standalone", and under
> -# "frame apply". The latter checks that the "frame apply ... COMMAND"
> -# commands recurse the completion machinery for COMMAND completion
> -# correctly.
> +# "frame apply COUNT|all|level". The latter checks that the "frame
> +# apply COUNT|all|level COMMAND" commands recurse the completion
> +# machinery for COMMAND completion correctly.

Hmm, in the "thread apply" patch (patch #22), I was changing this
comment to:

# Run the print integration tests, both as "standalone", and under
-# "frame apply". The latter checks that the "frame apply ... COMMAND"
-# commands recurse the completion machinery for COMMAND completion
-# correctly.
+# "frame/thread apply". The latter checks that the "frame/thread
+# apply ... COMMAND" commands recurse the completion machinery for
+# COMMAND completion correctly.

So I'm thinking that it's just simpler to leave it be as it was.

Thanks,
Pedro Alves