[PATCH 06/24] Fix "set enum-command value garbage"

Pedro Alves
2019-05-22T20:53:37Z

With enum commands, we currently fail to notice garbage after the
value.

Currently:

(gdb) set print entry-values compact foo
(gdb) show print entry-values foo
Printing of function arguments at function entry is "compact".

After this fix:

(gdb) set print entry-values compact foo
Garbage after item: "foo"

gdb/ChangeLog:
yyyy-mm-dd Pedro Alves <palves@redhat.com>

* cli/cli-setshow.c (do_set_command) <var_enum>: Detect garbage
after item.
---
gdb/cli/cli-setshow.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/gdb/cli/cli-setshow.c b/gdb/cli/cli-setshow.c
index 96d7bf5c3c0..9d6479ffca2 100644
--- a/gdb/cli/cli-setshow.c
+++ b/gdb/cli/cli-setshow.c
@@ -413,6 +413,10 @@ do_set_command (const char *arg, int from_tty, struct cmd_list_element *c)
if (nmatches > 1)
error (_("Ambiguous item \"%s\"."), arg);

+ arg = skip_spaces (arg + len);
+ if (*arg != '\0')
+ error (_("Garbage after item: \"%s\""), arg);
+
if (*(const char **) c->var != match)
{
*(const char **) c->var = match;
--
2.14.5