Re: [PATCH 12/24] Introduce generic command options framework

Philippe Waroquiers
2019-05-25T07:43:33Z

While quickly scanning the patch, I found a few typos ...

On Wed, 2019-05-22 at 21:53 +0100, Pedro Alves wrote:
> diff --git a/gdb/cli/cli-option.c b/gdb/cli/cli-option.c
> new file mode 100644
> index 00000000000..432555a953f
> --- /dev/null
> +++ b/gdb/cli/cli-option.c
...
> +/* Helper for build_help. Appends an indended version of DOC into
> + HELP. */
indended -> indented
> +
> +static void
> +append_indended_doc (const char *doc, std::string &help)
Same in the function name

> diff --git a/gdb/cli/cli-option.h b/gdb/cli/cli-option.h
> new file mode 100644
> index 00000000000..437fc09a61b
> --- /dev/null
> +++ b/gdb/cli/cli-option.h
...
> +struct option_def
> +{
> + /* The ctor is protected because you're supposed to construct using
> + one of bool_option_def, etc. below. */
> +protected:
> + typedef void *(erased_var_address_ftype) ();
> +
> + /* Construct an option. NAME_ is the option's name. VAR_TYPE_
> + defines the option's type. ERASED_VAR_ADDRESS_ is a pointer to
> + the option's control variable. SHOW_CMD_CB_ is a pointer to
Isn't ERASED_VAR_ADDRESS_ the address of a function ?

> diff --git a/gdb/testsuite/gdb.base/options.exp b/gdb/testsuite/gdb.base/options.exp
> new file mode 100644
> index 00000000000..924d7aa544e
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/options.exp
...
>
> +# Miscelaneous tests.
Miscellaneous