Re: [PATCH 20/24] Make "frame apply" support -OPT options

Pedro Alves
2019-05-29T15:13:09Z

On 5/25/19 9:12 PM, Philippe Waroquiers wrote:
> Some typos in the test.
>
> On Wed, 2019-05-22 at 21:53 +0100, Pedro Alves wrote:
>> @@ -3095,44 +32diff --git a/gdb/testsuite/gdb.base/options.exp b/gdb/testsuite/gdb.base/options.exp
>> index a4bd686fe5f..df5d86c0ece 100644
>> --- a/gdb/testsuite/gdb.base/options.exp
>> +++ b/gdb/testsuite/gdb.base/options.exp
>> + # tfaas is silent on comand error by design. This procedure
> comand -> command

Thanks, fixed.

>
>> # Miscelaneous tests.
> Miscelaneous -> Miscellaneous
> (maybe the same one as before?)

Yup.

>
>> proc_with_prefix test-misc {variant} {
>> global all_options
>> @@ -731,13 +807,28 @@ foreach_with_prefix cmd {
>> test-enum $cmd
>> }
>>
>> -# Run the print integration tests.
>> -test-print ""
>> +# Run the print integration tests, both as "standalone", and under
>> +# "frame apply". The latter checks that the "frame apply ... COMMAND"
>> +# commands recurse the completion machinery for COMMAND completion
> Not very clear what commands (with s) we speak about here ...
>

I meant all of "frame apply COUNT|level|all", which are implemented
as separate commands. I've changed it like this:

# Run the print integration tests, both as "standalone", and under
-# "frame apply". The latter checks that the "frame apply ... COMMAND"
-# commands recurse the completion machinery for COMMAND completion
-# correctly.
+# "frame apply COUNT|all|level". The latter checks that the "frame
+# apply COUNT|all|level COMMAND" commands recurse the completion
+# machinery for COMMAND completion correctly.

Thanks,
Pedro Alves