Re: [PATCH 00/24] gdb::option framework, "print -OPT", other cmd options

Sergio Durigan Junior
2019-05-24T19:58:48Z

On Wednesday, May 22 2019, Pedro Alves wrote:

> This all started a couple years ago with the idea that one reason
> people sometimes complain about gdb's defaults, such as "set print
> object" or "set print static-members" is that we don't have an easy
> way to override the global print settings.
[...]

Thanks a lot for the patch series, I think it's a great feature to have!

I have reviewed most of the patches so far, and pointed out some minor
things I noticed here and there, but overall this seems good (albeit a
bit complex to grok, like the gdb::option thing!).

I'll continue reviewing and will let you know if I find more things, but
I didn't want to block the progress of the feature, so I decided to send
this "LGTM" now.

Thanks,

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible