From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67886 invoked by alias); 21 Jun 2019 16:05:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67878 invoked by uid 89); 21 Jun 2019 16:05:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=s390x X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Jun 2019 16:05:42 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 209667D78 for ; Fri, 21 Jun 2019 11:05:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id eM2nhjFw0iQereM2nhFWoh; Fri, 21 Jun 2019 11:05:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UdMkiT8uUaLk2nJ1syhTHtzgMWJUpoZyHDywTAFhoBM=; b=m2HzyDmq4fmk+EZ97Yhl8IIgky vCY76qjAZIQmQ9NOERyJ0c3dntPmfVDrwKQ+CYRylp4XaKOTB8M9MjuExpDfgTZNTApRi6SmylwVi 2vMEz66YFsXq29hggcny3vFT7; Received: from 75-166-12-78.hlrn.qwest.net ([75.166.12.78]:54578 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1heM2m-000QR8-Sp; Fri, 21 Jun 2019 11:05:40 -0500 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org, Andreas Arnez Subject: Re: [PATCH][gdb] Fix s390x -m31 build References: <20190620093339.GA6388@delia> Date: Fri, 21 Jun 2019 16:05:00 -0000 In-Reply-To: <20190620093339.GA6388@delia> (Tom de Vries's message of "Thu, 20 Jun 2019 11:33:41 +0200") Message-ID: <87y31uc4a3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00431.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> Fix this by changing the length modifier from 'z' to the ptrdiff_t length Tom> modifier 't', and change the conversion specifier from 'u' to the more Tom> appropriate 'd'. gdb probably shouldn't be using 'z' anyway. IIRC it causes problems on Windows. How portable is %td? I do not know. Maybe check the gnulib manual and see what they have to say about it? Anyway, this is my main concern with this patch. The standard gdb approach here is to use plongest / pulongest in conjunction with %s. That avoids any problems. thanks, Tom