Re: [PATCH] Add block['var'] accessor

Christian Biesinger via gdb-patches
2019-08-05T18:30:46Z

On Mon, Aug 5, 2019 at 1:28 PM Simon Marchi <simark@simark.ca> wrote:
>
> On 2019-08-05 14:19, Christian Biesinger wrote:
> > On Mon, Aug 5, 2019 at 1:17 PM Simon Marchi <simark@simark.ca> wrote:
> >>
> >> On 2019-08-02 9:36 a.m., Tom Tromey wrote:
> >> > Christian> + struct symbol *sym = block_lookup_symbol (
> >> > Christian> + block, name.get(), symbol_name_match_type::FULL, VAR_DOMAIN);
> >> >
> >> > What about looking up things in other domains? I wonder if it's
> >> > possible to, say, have a local type that can be found by iteration over
> >> > the block but not by dictionary access. If so, that seems confusing.
> >>
> >> Just wondering, was this commented responded to?
> >
> > Oh sorry, in the most recent version of the patch I fixed it by using
> > ALL_BLOCK_SYMBOLS_WITH_NAME, which should match the behavior of the
> > iterator afaict.
>
> Ok, thanks!
>
> Note that it helps others (including the reviewer) if you acknowledge
> the comments, either with Ok / Done or "I'd rather not do that because
> X".

I did say at the top "Both issues should be fixed now." -- are you
suggesting it's better to individually acknowledge them? I'd be happy
to do that if y'all prefer.

Christian