From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127932 invoked by alias); 8 Aug 2019 16:58:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127923 invoked by uid 89); 8 Aug 2019 16:58:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1688 X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.48.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Aug 2019 16:58:51 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway23.websitewelcome.com (Postfix) with ESMTP id BB8CE84F3 for ; Thu, 8 Aug 2019 11:58:49 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vlkWhwKS13Qi0vlkXhfFqt; Thu, 08 Aug 2019 11:58:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gQCKxCSe5kFekzFELn550VJ1EyOz45Jv/sqN188upkI=; b=w/lb8LOGaGqM+vb6qJVlGUdtF1 IYIcF5PC3bt6JPIfSYP6QGzrs+pVYwqs9aXrqxEJICA6c7FHJw5aShlet7hVtE6M99seTP1pCmTVN MuyGK1xTrZV7BfULBrQez7ohq; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:34842 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hvlkW-0025d6-Lw; Thu, 08 Aug 2019 11:58:48 -0500 From: Tom Tromey To: Pedro Alves Cc: Alan Hayward , "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH V2] AArch64 pauth: Indicate unmasked addresses in backtrace References: <20190730144123.11135-1-alan.hayward@arm.com> <728af5fa-8e3d-845c-d72f-60b1d2067643@redhat.com> Date: Thu, 08 Aug 2019 16:58:00 -0000 In-Reply-To: <728af5fa-8e3d-845c-d72f-60b1d2067643@redhat.com> (Pedro Alves's message of "Wed, 7 Aug 2019 20:24:39 +0100") Message-ID: <87y30361bs.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00202.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Hmm, I had suggested considering MI in the previous iteration, but Pedro> I was just thinking of including the "[PAC]" text in the Pedro> "addr" field. If we're adding a new field, then a few extra Pedro> things need to be considered: Pedro> #1 - documentation, both manual and NEWS should mention this new MI field. Oops, I forgot about this. Sorry about that. I don't think putting this information into the "addr" field is a good idea. It's better, IMO, to let MI field names provide the structure, rather than requiring clients to also parse the values of fields. I realize MI isn't 100% clean on this topic, but we can still not make it worse. Pedro> #2 - calling the attribute "pac" makes it architecture specific. I don't think this is such a big deal but at the same time any reasonable name is fine by me. Pedro> #3 - The MI attribute is called "pac", and its content is Pedro> literally " [PAC]". I'd find that odd if I were a frontend author: Pedro> the content is right aligned with a space, making doing anything with Pedro> it other than appending it to the address text probably look odd, Pedro> unless you bake in awareness of the attribute's text... If I saw Pedro> an attribute named "pac", I'd expect it to be a boolean? At the Pedro> least, the left space should not be part of the field, I think? I think part of the pain here is an internal constraint, namely that the CLI ui-out wouldn't know to rewrite the boolean value to something else here. But perhaps that's something that could just be addressed directly. Tom