Re: [PATCH 1/6] Introduce scoped_pipe.h

Tom Tromey
2020-02-28T15:23:31Z

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> gdb/ChangeLog:
Sergio> yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com>

Sergio> * unittests/scoped_pipe-selftests.c: New file.

Sergio> gdbsupport/ChangeLog:
Sergio> yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com>

Sergio> * scoped_pipe.h: New file.

I think new general-purpose code should go in gdbsupport.

Unfortunately right now we don't have a good way to put the unit tests
there. This is something we ought to do eventually though.

Sergio> +#ifndef COMMON_SCOPED_PIPE_H

I think we've been using GDBSUPPORT rather than COMMON now.

Sergio> + explicit scoped_pipe ()

I think explicit is only needed for 1-arg constructors.

Tom