From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91616 invoked by alias); 10 Oct 2019 15:58:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91604 invoked by uid 89); 10 Oct 2019 15:58:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.147) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2019 15:58:57 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway21.websitewelcome.com (Postfix) with ESMTP id DF193402E598D for ; Thu, 10 Oct 2019 10:58:54 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Iaq6ibQnCPUvSIaq6iDhm8; Thu, 10 Oct 2019 10:58:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/oSdMRAZh32739QaJ4Jp7m0FakL83FIt1uQdCXys5pU=; b=Iz/93NzXRh/+uSm2qGUrbctaYU SyrxlAIMaNTRfBlzsgtshOra2FvzEuhzRQzFHLX2UaBAo+BsoMzJlgt6PLcpHuagpXOkxB/DFMzKs UE8C2i5aN9QEg5ahdsvWotxGK; Received: from 174-29-53-230.hlrn.qwest.net ([174.29.53.230]:35550 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iIaq6-001e6b-Lf; Thu, 10 Oct 2019 09:58:54 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches Subject: Re: [PATCHv2 4/4] gdb: Add new commands to list module variables and functions References: <2572574a445f9f32b4cca9a6f767d8495f4503c1.1570101531.git.andrew.burgess@embecosm.com> Date: Thu, 10 Oct 2019 15:58:00 -0000 In-Reply-To: <2572574a445f9f32b4cca9a6f767d8495f4503c1.1570101531.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Thu, 3 Oct 2019 12:29:17 +0100") Message-ID: <87y2xs7fsy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-10/txt/msg00278.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> This patch adds two new commands "info module functions" and "info Andrew> module variables". These commands list all of the functions and Andrew> variables grouped by module and then by file. Andrew> + if(type_regexp == nullptr) ... Andrew> + if(type_regexp == nullptr) I noticed these two lines were missing a space after the "if". Tom