From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71403 invoked by alias); 25 Nov 2019 22:08:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71395 invoked by uid 89); 25 Nov 2019 22:08:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=price, pay X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.94) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2019 22:08:37 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 69970430CF for ; Mon, 25 Nov 2019 16:08:36 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ZMX6iVJUL4kpjZMX6i7xcd; Mon, 25 Nov 2019 16:08:36 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9GzNOopA71DcsZsyWviks8gf1LnVepmJHAk57os6ikk=; b=tcD32gxf5h6FzHQElmhq74Js2c rFQ8kJv4DScDrdq7C5/5Eo/EVh/KSz6SJBvA+sn24GF7EFhTCRXmuAbi+rj8q+Y3kfvVFXuzCpB4C pxrvQtkeHA9gq8m28q855nIeR; Received: from 97-118-104-188.hlrn.qwest.net ([97.118.104.188]:51278 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iZMX6-0018dC-7G; Mon, 25 Nov 2019 15:08:36 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 00/15] Enable -Wmissing-declarations diagnostic References: <20191125052655.22696-1-simon.marchi@efficios.com> Date: Mon, 25 Nov 2019 22:08:00 -0000 In-Reply-To: <20191125052655.22696-1-simon.marchi@efficios.com> (Simon Marchi's message of "Mon, 25 Nov 2019 00:26:40 -0500") Message-ID: <87y2w37gnw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-11/txt/msg00849.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> This series does a bunch of fixes that lead to enabling Simon> -Wmissing-declarations. In my experience (and as shown by the fixes Simon> done by this series), this warning is helpful to detect few classes of Simon> buglets, from forgetting to include foo.h in foo.c, to having a function Simon> that should be static be not static and having declarations not in sync Simon> with definitions (although this one is less likely to be a problem with Simon> C++). I read through this series and it all looked good to me. Like you, I think this is a good idea. Patch #1 is maybe mildly unfortunate, but that seems like a small price to pay. I sent one comment to the final patch. thanks, Tom