From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28672 invoked by alias); 19 Dec 2019 19:24:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28664 invoked by uid 89); 19 Dec 2019 19:24:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.31) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 19:24:35 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway31.websitewelcome.com (Postfix) with ESMTP id F1F11355CF9 for ; Thu, 19 Dec 2019 13:24:13 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id i1PBil4JB4kpji1PBiIa4G; Thu, 19 Dec 2019 13:24:13 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Yu2+8wd++oxhaeGfD6dIELGhpHw7XvaP3pzQkQjsAvA=; b=kSup6X780f432kxFpKGInrsHbc Nbhhfr2wO9d9ZzP/kEZKpLsRFLKGCL+UaIm+Plnm21SOJ1mkMI6KJ5QdaBXdze2SBh6c8brRuhvUx IMOegGJHG3NYroa3MmRWWn2VZ; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:38102 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ii1PB-001Tiw-OQ; Thu, 19 Dec 2019 12:24:13 -0700 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH] Consistently quote variables used with "test" References: <20191218210608.211751-1-cbiesinger@google.com> Date: Thu, 19 Dec 2019 19:24:00 -0000 In-Reply-To: <20191218210608.211751-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Wed, 18 Dec 2019 15:06:08 -0600") Message-ID: <87y2v886g2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00835.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> This ensures that empty variables and variables with spaces are handled Christian> correctly. Christian> Code was inconsistent on whether the constant string (e.g. yes/no) Christian> should also be quoted; I tried to be consistent with surrounding code. Christian> This fixes the error Eli reported during configure with mingw (though that Christian> was not fatal). Thanks. This is ok. Tom