From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66733 invoked by alias); 7 Jan 2020 18:54:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66720 invoked by uid 89); 7 Jan 2020 18:54:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=screen X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.61.9) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Jan 2020 18:54:51 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 4E320400CF74C for ; Tue, 7 Jan 2020 11:43:04 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ou0AiJX1oqNtvou0AiwwsP; Tue, 07 Jan 2020 12:54:50 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=T0wOOQBSNsmsOKbUcjzh2TrfOB7Tsc8vWbGl6DqXShc=; b=cX52G0p7neHIqqlV2rP6IcdpDb bxMSGg8pysbGndVfF3FCpQGFAePURaxGhimYeGetBKL+AFGaTsnwAC7qvcbGdVJ3f0DSxhKIKUtAB HQnRoLJgfCWIGTNTCONvsy2pS; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:37426 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iou0A-001UJh-89; Tue, 07 Jan 2020 11:54:50 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Tom Tromey , Hannes Domani Subject: Re: [PATCH 1/6] gdb/testsuite/tui: Always dump_screen when asked References: <874kxrc3ha.fsf@tromey.com> <46c21f67261de4d1129918af411b068512c0ab16.1578397591.git.andrew.burgess@embecosm.com> Date: Tue, 07 Jan 2020 18:54:00 -0000 In-Reply-To: <46c21f67261de4d1129918af411b068512c0ab16.1578397591.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Tue, 7 Jan 2020 11:52:14 +0000") Message-ID: <87y2ujf66e.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00154.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> The Term::dump_screen routine currently dumps the screen using calls Andrew> to 'verbose', this means it will only dump the screen when the Andrew> testsuite is running in verbose mode. Andrew> However, the Term::dump_screen is most often called when a test fails, Andrew> in this case I think it is useful to have the screen dumped even when Andrew> we're not in verbose mode. Andrew> This commit changes the calls to 'verbose' to be 'verbose -log' so we Andrew> always get the screen dump. Andrew> gdb/testsuite/ChangeLog: Andrew> * lib/tuiterm.exp (Term::dump_screen): Always dump the screen when Andrew> called. Seems reasonable to me. Thanks. Tom