From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75192 invoked by alias); 12 Feb 2020 22:41:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75179 invoked by uid 89); 12 Feb 2020 22:41:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.187) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 22:41:20 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway22.websitewelcome.com (Postfix) with ESMTP id B5D187FA for ; Wed, 12 Feb 2020 16:41:18 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 20h4jAFObAGTX20h4jMPFo; Wed, 12 Feb 2020 16:41:18 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qPUR7bKAtT5DsPnaoTtSzRxHBk7KoD4dAt1cdr9SBlM=; b=uo/rluaziUtd+qSTgfWzOxBn2y +aP5Yd0a58wagPdNs6bd3JStv/Hb342TVryL7NiiUWdMiaTzhhGCprWuB62TuIwicJJgY9YcrS8Pv Q5YocjOFz+gDjRClaMtWInpNX; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:56228 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j20h4-001fII-GT; Wed, 12 Feb 2020 15:41:18 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 5/8] Add per-unit obstack References: <20200208152758.29385-1-tom@tromey.com> <20200208152758.29385-6-tom@tromey.com> <8e13cd77-cbe8-4549-5ff3-2cb5fbe32b47@simark.ca> Date: Wed, 12 Feb 2020 22:41:00 -0000 In-Reply-To: <8e13cd77-cbe8-4549-5ff3-2cb5fbe32b47@simark.ca> (Simon Marchi's message of "Tue, 11 Feb 2020 22:53:51 -0500") Message-ID: <87y2t7qvhu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00469.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Would it be simpler to eliminate the obstack by making dwarf2_cie_table Simon> and dwarf2_fde_table hold objects instead of pointers? On top of that, Simon> it should be good for performance as well, at least when doing lookups. Simon> The only issue is that dwarf2_cie objects are referenced by address by Simon> the FDEs, so we must make sure they don't get moved by the container. Simon> But I believe std::unordered_map guarantees that (disabling copy and Simon> assign on dwarf2_cie would verify it). Or worst case, the it could Simon> be an std::unordered_map of std::unique_ptr. I think I would rather defer this change, like the other one, since it's not directly related to the purpose of the series. Tom