From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112577 invoked by alias); 22 Feb 2020 18:05:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112550 invoked by uid 89); 22 Feb 2020 18:05:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.38) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Feb 2020 18:05:02 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway21.websitewelcome.com (Postfix) with ESMTP id AEDD6400CA74D for ; Sat, 22 Feb 2020 12:05:00 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 5Z9AjwUHUAGTX5Z9Aj6dj1; Sat, 22 Feb 2020 12:05:00 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=so/cn9I5q+Dc+9E2kjL8SUx+sTrvp3tBJxT6bxL/Edo=; b=uYf6umpn7Vbxcwhs1NkfvXv7Fc mqulV1RbXSfW0Rk8gglxPK8ppMfH045VZfbEpdZlzfnj5fntj4FFy4oVcZ59COoZyPdcS+oRVqzQk SK6JvbppgrNjkLYzUQlPN4pyn; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:57138 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j5Z9A-003v0y-AC; Sat, 22 Feb 2020 11:05:00 -0700 From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , midenok@gmail.com, gdb@sourceware.org, gdb-patches@sourceware.org Subject: Re: GDB 9 TUI mode broken References: <835zg5m7ib.fsf@gnu.org> <83mu9aj1pj.fsf@gnu.org> Date: Sat, 22 Feb 2020 18:05:00 -0000 In-Reply-To: <83mu9aj1pj.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 22 Feb 2020 13:33:44 +0200") Message-ID: <87y2su5whg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00887.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: Eli> Tom, where's the position update of the status line supposed to be Eli> handled? I looked at the gdb-9 branch. In tui_adjust_win_heights, it is code like this: locator->resize (1, width, 0, (second_win->origin.y + second_win->height + 1)); Eli> And btw, the meaning of the 'locator' object in tui_adjust_win_heights Eli> is unclear: to which window does it pertain, and what is the Eli> significance of this line: You and Simon discussed this down-thread. FWIW the name "locator" has been used in the source since the beginning; but I also don't particularly care for it (for a long time I could never remember the name and had to search to find it whenever I needed it). So, I would appreciate a rename in the code here as well. Also, thanks for pointing out that this is called "status" in the docs. That affects my other series to make user-specified layouts. In that series I called the window "locator" -- but I'm going to go rename it. Eli> TUI_CMD_WIN-> origin.y = locator->origin.y + 1; This is a leftover and should be removed. The resize method is the way to modify a window's size and position. This code is all different on git master. Your patch looks reasonable to me. Tom