From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89761 invoked by alias); 23 Feb 2020 23:58:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89752 invoked by uid 89); 23 Feb 2020 23:58:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=afraid, objfiles X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.186.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 23 Feb 2020 23:58:17 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 04C5D40FA0743 for ; Sun, 23 Feb 2020 17:12:52 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 618VjLqbOAGTX618VjViin; Sun, 23 Feb 2020 17:58:11 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4ZMZ5dByBjOqU2YVvtEZQQITJbzAubT5yIlcfrpn9Rw=; b=jtp+mdzUyJ5uhzV5cYQH6NOCh2 t3DkcW1dJY7fVtgTMhjKKKQJ/VGz3fPG816LkpDwCUNxb+Zt18RoRs9W6ydvsMO8jEjiei455cGmS Eba85JipSr1bFXYiG9tjJ6XAl; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:34742 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j618V-002KDP-5W; Sun, 23 Feb 2020 16:58:11 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 00/14] Share DWARF partial symtabs between objfiles In-Reply-To: (Simon Marchi's message of "Sat, 22 Feb 2020 21:37:05 -0500") References: <20200215165444.32653-1-tom@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sun, 23 Feb 2020 23:58:00 -0000 Message-ID: <87y2ss5019.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00904.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I think it would be more natural and easier to understand to have : Simon> objfile -> dwarf2 objfile-specific object -> dwarf2 object shared between objfiles Simon> Many "dwarf2 objfile-specific" objects would point to one "dwarf2 object shared between Simon> objfiles", without special tricks. Of course, it's much easier said than done. Simon> I'd like to know: did you consider this way of doing it and chose not to do it Simon> because of the complexity / size of the change? Is the current patchset a stepping Simon> stone towards it? I was afraid of the size of the resulting patch. However, I think you're right that this would be better. And, I feel pretty strongly that we should be making the DWARF reader less awful, not more. Probably the thing to do is reorder the series a little (some patches don't depend on this), then redo the "unsharing" patch, and finally update the subsequent patches. A few of these patches (1-3, 5, and 11) could probably go in sooner. What do you think of that? Tom