From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.63.14]) by sourceware.org (Postfix) with ESMTPS id A2166385E006 for ; Thu, 26 Mar 2020 02:17:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A2166385E006 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 6E639400DB59D for ; Wed, 25 Mar 2020 20:01:56 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id HI5YjYDlTSl8qHI5Yj5VUq; Wed, 25 Mar 2020 21:17:44 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6Fpkh+fegUM5uqOHYXvJ642kDYvZAfYLd9LMI+zjc2o=; b=JcVARJv/hgicmKinDc50Hs2ENu HX+L10/mi44cVQ4Ivm6bsY3zPC+ONJ34o/nTJANnNHLDEMnIJaSp769mGfZDcCgwBk1uH7EWaFAwz 6rGvuzmbg48hCVqe4j6fqOWwE; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:59952 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jHI5Y-000RPU-0Z; Wed, 25 Mar 2020 20:17:44 -0600 From: Tom Tromey To: Christian Biesinger Cc: Tom Tromey , gdb-patches Subject: Re: [PATCH 19/22] Change two more functions to be methods on die_info References: <20200322184523.28959-1-tom@tromey.com> <20200322184523.28959-20-tom@tromey.com> X-Attribution: Tom Date: Wed, 25 Mar 2020 20:17:43 -0600 In-Reply-To: (Christian Biesinger's message of "Mon, 23 Mar 2020 14:07:26 -0500") Message-ID: <87y2rnc114.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.117.21 X-Source-L: No X-Exim-ID: 1jHI5Y-000RPU-0Z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-117-21.hlrn.qwest.net (bapiya) [97.118.117.21]:59952 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2020 02:17:45 -0000 >>>>> "Christian" == Christian Biesinger writes: >> + attr = attr (DW_AT_addr_base); Christian> I get that you want to avoid making code changes while moving code but Christian> I would really suggest merging these two lines at least (similar in Christian> the next function) This line doesn't even compile actually. I must have only built this after writing the next patch? Ugh. Anyway I changed it as you suggest and used this->attr, which I normally wouldn't do, but thought was ok since this patch is just a transition. Tom